[CircleGraph] Implement visqselector mode#1545
Merged
seanshpark merged 1 commit intoSamsung:mainfrom May 3, 2023
Merged
Conversation
dayo09
reviewed
May 2, 2023
Contributor
There was a problem hiding this comment.
(optional) How about returning 'if not' condition here to reduce the level of condition?
Like,
if (!viewMode) {return}
if (this._host._mode === viewMode.selector || this._host._mode === viewMode.visqselector) {return}
// continuous logic
Contributor
Author
There was a problem hiding this comment.
@dayo09
Thank you. Unfortunately there are 4 values, including visqselector, so inverting logic will still produce:
if (this._host._mode !== viewMode.viewer && this._host._mode !== viewMode.visq) {return}
// continuous logic
Contributor
There was a problem hiding this comment.
I mean, if it's not 'viewMode', then this function don't need to proceed. Note that it's an 'and' condition. 😄
Contributor
Author
There was a problem hiding this comment.
Ahhh. Sorry. I didn't immediately understand that.
dayo09
previously approved these changes
May 2, 2023
seanshpark
reviewed
May 2, 2023
seanshpark
reviewed
May 2, 2023
stamalakhov
force-pushed
the
manual_MPQ_graph_med_br
branch
from
753a5c3 to
37ad016
Compare
seanshpark
reviewed
May 2, 2023
stamalakhov
force-pushed
the
manual_MPQ_graph_med_br
branch
from
37ad016 to
21c06c3
Compare
dayo09
previously approved these changes
May 2, 2023
This commit implements visqselector mode and managing of scrollToSlected. ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov <s.malakhov@partner.samsung.com>
stamalakhov
force-pushed
the
manual_MPQ_graph_med_br
branch
from
21c06c3 to
c5c37c9
Compare
dayo09
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements visqselector mode and managing of scrollToSlected.
Its correctness is tested in #1543
Fresh draft: #1543
Full draft: #1505
Related: #1491
ONE-vscode-DCO-1.0-Signed-off-by: s.malakhov s.malakhov@partner.samsung.com