Skip to content

Remove Suspense wrappers from public policy routes #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SaravanakumarR2018 wants to merge 1 commit into
base: codex/replace-link-with-anchor-tag-in-policies
Choose a base branch
from
Open

Remove Suspense wrappers from public policy routes #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions src/frontend/src/routes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,27 +378,15 @@ const router = createBrowserRouter(
{/* Public policy routes */}
<Route
path="terms-of-service"
element={
<Suspense fallback={<LoadingPage />}>
<TermsOfServicePage />
</Suspense>
}
element={<TermsOfServicePage />}
/>
Comment on lines 379 to 382

@chatgpt-codex-connector chatgpt-codex-connector Bot Jan 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore Suspense boundary for lazy policy pages

These policy routes still render React.lazy components (TermsOfServicePage, PrivacyPolicyPage, RefundPolicyPage are declared with lazy(...) at the top of this file). With the Suspense wrappers removed, navigating to these routes will throw at runtime (“a component suspended while rendering, but no fallback UI was specified”) because this branch of the route tree only has ContextWrapper/Outlet and no ancestor Suspense boundary. This means public policy pages will fail to render in production unless a higher-level Suspense is reintroduced.

Useful? React with 👍 / 👎.

<Route
path="privacy-policy"
element={
<Suspense fallback={<LoadingPage />}>
<PrivacyPolicyPage />
</Suspense>
}
element={<PrivacyPolicyPage />}
/>
<Route
path="refund-policy"
element={
<Suspense fallback={<LoadingPage />}>
<RefundPolicyPage />
</Suspense>
}
element={<RefundPolicyPage />}
/>

{/* Auth routes */}
Expand Down
Loading