Simplify noop send_message signature - #383
Open
SaravanakumarR2018 wants to merge 1 commit into
Open
Conversation
|
Hi! I'm the It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
skip_db_update) instead of introducing a separate module.skip_db_updateis sent during agent streaming to avoid repeated DB writes and must be accepted by patched/no-opsend_messageimplementations to prevent runtime errors.Description
src/lfx/src/lfx/base/tools/component_tool.pynamedsend_message_noopand added a catch-all**_: objectparameter so it accepts extra keyword arguments (includingskip_db_update).src/lfx/src/lfx/base/tools/send_message_noop.pyand the import that referenced it to keep the change minimal.patch_components_send_messageand_patch_send_message_decoratorlogic remain unchanged and now assign the localsend_message_noopto the component.Testing
Codex Task