Skip to content

Simplify noop send_message signature - #383

Open
SaravanakumarR2018 wants to merge 1 commit into
codex/fix-agent-component-update-prompt-x59y17from
codex/fix-unexpected-keyword-argument-error
Open

Simplify noop send_message signature#383
SaravanakumarR2018 wants to merge 1 commit into
codex/fix-agent-component-update-prompt-x59y17from
codex/fix-unexpected-keyword-argument-error

Conversation

@SaravanakumarR2018

Copy link
Copy Markdown
Owner

Motivation

  • Avoid a large refactor and keep the change minimal by making the noop tolerate newer kwargs (like skip_db_update) instead of introducing a separate module.
  • skip_db_update is sent during agent streaming to avoid repeated DB writes and must be accepted by patched/no-op send_message implementations to prevent runtime errors.

Description

  • Restored a local noop in src/lfx/src/lfx/base/tools/component_tool.py named send_message_noop and added a catch-all **_: object parameter so it accepts extra keyword arguments (including skip_db_update).
  • Removed the separate module src/lfx/src/lfx/base/tools/send_message_noop.py and the import that referenced it to keep the change minimal.
  • The patch_components_send_message and _patch_send_message_decorator logic remain unchanged and now assign the local send_message_noop to the component.

Testing

  • No automated tests were executed for this change (no test run requested).

Codex Task

@autofix-troubleshooter

Copy link
Copy Markdown

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants