Skip to content

Accept lightning-prefixed LNURLs in Satoshifier #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BullishNode wants to merge 1 commit into
base: test/liquid-consolidation-v2
Choose a base branch
from
Open

Accept lightning-prefixed LNURLs in Satoshifier #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/satoshifier/example/integration_test/lnurl_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,13 @@ void main() {
expect(result, isNotNull);
}
});

test('strips the lightning scheme from an uppercase LNURL', () async {
final lnurl = TestValue.lnurlUppercase as String;
final result = await Satoshifier.parse('lightning:$lnurl');

expect(result, isA<Lnurl>());
expect((result as Lnurl).address, lnurl);
});
});
}
12 changes: 8 additions & 4 deletions packages/satoshifier/lib/parsers/lnurl_parser.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,20 @@ import 'package:satoshifier/satoshifier.dart';
class LnurlParser {
static Future<Satoshifier> parse(String input) async {
try {
final isEmail = input.contains('@');
final isPrefixed = input.toLowerCase().startsWith('lnurl');
final normalized = input.trim().replaceFirst(
RegExp(r'^lightning:', caseSensitive: false),
'',
);
final isEmail = normalized.contains('@');
final isPrefixed = normalized.toLowerCase().startsWith('lnurl');

if (!isEmail && !isPrefixed) throw 'Invalid LNURL: $input';

final lnurl = boltz.Lnurl(value: input);
final lnurl = boltz.Lnurl(value: normalized);
final isValid = await lnurl.validate();
if (!isValid) throw 'Invalid LNURL: $input';

return Satoshifier.lnurl(address: input);
return Satoshifier.lnurl(address: normalized);
} catch (_) {
rethrow;
}
Expand Down