fix: handle non-standard BIP21 URIs in QR scanner - #2300
Merged
i5hi merged 7 commits intoJun 16, 2026
Conversation
9 tasks
Collaborator
|
Example test cases that cover the following:
|
Collaborator
Author
|
@i5hi, added unit tests for all cases and fixed the parser to correctly handle the third one:
|
i5hi
approved these changes
Jun 16, 2026
| if (result != null) return result; | ||
| } | ||
|
|
||
| final re = RegExp(r'lnurl[0-9a-z]+', caseSensitive: false); |
Collaborator
There was a problem hiding this comment.
this may not cover all cases and in some cases may have extra information. added test cases.
this makes 2 assumptions:
- the string will only be lnurl format - skips bolt11 and lnaddress formats
- there will be no additional data after the lnurl string - in some cases there maybe more query params like label, message or other network addresses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #2202
ScreenRecording_06-16-2026.10-16-14_1.MP4