feat: Add Coldcard MK4 and Coldcard Q NFC by ben-kaufman - #1314
Closed
ethicnology wants to merge 5 commits into
Closed
feat: Add Coldcard MK4 and Coldcard Q NFC by ben-kaufman#1314ethicnology wants to merge 5 commits into
ben-kaufman#1314ethicnology wants to merge 5 commits into
Conversation
Member
Author
|
LGTM |
Member
Author
|
@i5hi does NFC permission change anything to your publication process ? |
ethicnology
commented
Oct 15, 2025
| <uses-permission android:name="android.permission.INTERNET"/> | ||
| <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/> | ||
| <!-- <uses-permission android:name="android.permission.NFC"/> --> | ||
| <uses-permission android:name="android.permission.NFC"/> |
Member
Author
There was a problem hiding this comment.
NFC was disabled probably because of stores publication process.
May be delayed into another release
cc @i5hi
Member
Author
|
This PR seems now stale and very out of sync, should we close it ? |
Member
Author
|
Closed in favor of #2224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1284