feat: localization of core/bitbox - #1631
Merged
ethicnology merged 1 commit intoDec 5, 2025
Merged
Conversation
Add localization for BitBox hardware wallet integration: - Convert BitBoxAction getters to methods with BuildContext parameter - Localize all BitBoxError messages with toTranslated pattern - Update bitbox_action_screen.dart with localized UI strings - Add 68 new ARB keys for screen status, buttons, and error messages
ethicnology
approved these changes
Dec 5, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localization: core/bitbox
Overview
lib/core/bitboxandlib/features/bitboxlocalization/core-bitboxChanges
Implementation Pattern
This follows the toTranslated() method pattern (like RecoverBullError):
BitBoxErrorstores error object in state (not String)error.toTranslated(context)for localized display$e(toString of error)Localized Strings
Error Messages (14 keys):
bitboxErrorPermissionDenied,bitboxErrorNoDevicesFound,bitboxErrorMultipleDevicesFoundbitboxErrorDeviceNotFound,bitboxErrorConnectionTypeNotInitialized,bitboxErrorNoActiveConnectionbitboxErrorDeviceMismatch,bitboxErrorInvalidMagicBytes,bitboxErrorDeviceNotPairedbitboxErrorHandshakeFailed,bitboxErrorOperationTimeout,bitboxErrorConnectionFailedbitboxErrorInvalidResponse,bitboxErrorOperationCancelledBitBox Actions (30 keys):
Screen UI (24 keys):
Code Changes
toTranslated(BuildContext context)methodtitle→toTitle(context))String? errorMessagetoBitBoxError? errorcontext.loc.*and pattern matching for errorsValidation Results
✅ validate_localizations.py - All 2658 keys synchronized
✅ flutter analyze --fatal-warnings --fatal-infos - No issues found
Testing