feat: localization of core/swaps - #1643
Merged
ethicnology merged 1 commit intoDec 9, 2025
Merged
Conversation
Localize swap status display names, swap actions, and status messages: - Convert SwapStatus.displayName getter to method with context - Convert Swap.swapAction getter to method with context - Convert SwapStatusMessage.getDisplayMessage to method with context - Convert WalletTransactionStatus.displayName getter to method with context - Add 38 ARB keys (coreSwaps*, coreWalletTransaction*) - Update transaction UI to use localized methods
Member
ethicnology
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localize
core/swapsmodule with 38 new translation keys for swap status display names, swap actions, and status messages.Changes:
SwapStatus.displayNamegetter to method withBuildContextparameterSwap.swapActiongetter to method withBuildContextparameterSwapStatusMessage.getDisplayMessage()to method withBuildContextparameterWalletTransactionStatus.displayNamegetter to method withBuildContextparameterNew ARB Keys (38 total):
coreSwapsStatus*coreSwapsAction*coreSwapsLnReceive*coreSwapsLnSend*coreSwapsChain*coreWalletTransactionStatus*Files Modified:
lib/core/swaps/domain/entity/swap.dart- Localized status/action/message methodslib/core/wallet/domain/entities/wallet_transaction.dart- Localized status displayNamelib/features/transactions/ui/screens/transaction_details_screen.dart- Updated swapAction calllib/features/transactions/ui/widgets/transaction_details_table.dart- Updated displayName/getDisplayMessage callslocalization/app_en.arb- 38 new English keyslocalization/app_fr.arb- 38 new French translationslocalization/app_es.arb- 38 new Spanish translationsTest Plan
fvm flutter analyze --fatal-warnings --fatal-infos- passespython3 linux/validate_localizations.py- passesNotes
displayName(context)pattern used invault_provider.darttoTranslated()pattern is specifically for error classes, not entity enums