feat: custom mempool url - #1688
Merged
Merged
Conversation
Contributor
Author
|
I think I need to use inline inserts instead of DatabaseSeeds in schema 10 to 11 where I have added the default mempool URL seeding, but I don't understand exactly why. Other than that, everything else should be fine and the PR is ready to be reviewed |
Contributor
Author
|
Implements issue #1569 |
ethicnology
requested changes
Dec 22, 2025
Contributor
Author
|
basantagoswami
force-pushed
the
custom-mempool-server
branch
from
December 22, 2025 15:14
f5b61a2 to
0b85d53
Compare
i5hi
approved these changes
Dec 23, 2025
| } | ||
|
|
||
| static Future<void> seedDefaultMempoolServers(SqliteDatabase db) async { | ||
| final serversData = [ |
Collaborator
There was a problem hiding this comment.
These should be in the contants file and read here.
| // Bitcoin mempool | ||
| static const bbMempoolUrlPath = 'mempool.bullbitcoin.com'; | ||
| static const publicMempoolUrlPath = 'mempool.space'; | ||
| static const publicMempoolUrlPath = 'mempool.space'; // note: not used |
Collaborator
There was a problem hiding this comment.
lets remove it if we arent using it.
| static const bbLiquidMempoolTestnetUrlPath = 'liquid.bullbitcoin.com/testnet'; | ||
| static const publicLiquidMempoolUrl = 'https://liquid.network'; | ||
| static const publicLiquidMempoolTestnetUrl = 'https://liquid.network/testnet'; | ||
| static const publicLiquidMempoolUrl = |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.