feat: add announcements feature to exchange module - #1717
Merged
Conversation
mocodesmo
commented
Dec 30, 2025
mocodesmo
commented
Contributor
- Introduced GetAnnouncementsUsecase for fetching announcements.
- Updated ExchangeLocator to register the new use case.
- Implemented listAnnouncements method in ExchangeUserRepository.
- Added API call in BullbitcoinApiDatasource to retrieve announcements.
- Enhanced ExchangeCubit to load and manage announcements state.
- Integrated AnnouncementBanner in ExchangeHomeScreen for display.
- Introduced GetAnnouncementsUsecase for fetching announcements. - Updated ExchangeLocator to register the new use case. - Implemented listAnnouncements method in ExchangeUserRepository. - Added API call in BullbitcoinApiDatasource to retrieve announcements. - Enhanced ExchangeCubit to load and manage announcements state. - Integrated AnnouncementBanner in ExchangeHomeScreen for display.
Member
|
@claude can you give your opinion on this PR ? |
i5hi
approved these changes
Dec 31, 2025
| ); | ||
| if (apiKey == null) { | ||
| throw ApiKeyException( | ||
| 'API key not found. Please login to your Bull Bitcoin account.', |
Collaborator
There was a problem hiding this comment.
Text should go in the localizations files
Member
There was a problem hiding this comment.
I'm not sure but I think this is an error that doesn't reach the user level, so only in logs
Contributor
Author
There was a problem hiding this comment.
none of the APIKeyExceptions are localised (35 occurrences) .
@i5hi pls confirm what to do here
i5hi
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.