iOS accessibility migration - #1776
Closed
kumulynja wants to merge 1 commit into
Closed
Conversation
…, check if saved with unlocked policy and migrate on demand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS accessibility in the
FlutterSecureStorageinstance was changed fromunlockedtofirst_unlock_this_deviceto let the background processes have access to the data stored in secure storage. However, this means the data itself should be migrated to get this less restrictive policy as well, otherwise the background tasks will still find nothing, since the data was previously written with more restrictive accessibility policy. This PR does a dynamic on-demand migration when the data is not found with thefirst_unlock_this_devicepolicy. It will then check it with theunlockedpolicy and then write it to an item in secure storage with thefirst_unlock_this_devicepolicy, so next time it will find it there right away and the background tasks can access that now as well.