Skip to content

fix: update Spanish auto transfer settings label - #2284

Merged
ethicnology merged 1 commit into
developfrom
2278-shorten-spanish-label-for-auto-transfer-settings
Jun 11, 2026
Merged

fix: update Spanish auto transfer settings label#2284
ethicnology merged 1 commit into
developfrom
2278-shorten-spanish-label-for-auto-transfer-settings

Conversation

@wired-pasteque

Copy link
Copy Markdown
Collaborator

Fix: #2278

Simulator Screenshot - iPhone 16e - 2026-06-11 at 09 35 43 Simulator Screenshot - iPhone 16e - 2026-06-11 at 09 35 47

@wired-pasteque wired-pasteque self-assigned this Jun 11, 2026
@wired-pasteque wired-pasteque linked an issue Jun 11, 2026 that may be closed by this pull request
5 tasks
@claude

claude Bot commented Jun 11, 2026

Copy link
Copy Markdown

Claude finished @wired-pasteque's task in 52s —— View job


Code Review — Spanish auto-transfer label

  • Read the diff (localization/app_es.arb)
  • Check JSON validity & key consistency
  • Compare against English source labels
  • Post review

Summary: This is a clean, low-risk localization-only change. It shortens the four auto-transfer title labels from "Configuración de transferencia automática""Transferencia automática" and also fixes inconsistent indentation on two unrelated fundExchange* lines. No correctness, security, or regression concerns.

Verified:

  • ✅ JSON remains well-formed — trailing commas and structure intact (checked lines around each edit).
  • ✅ All three auto-transfer keys updated consistently (bitcoinSettingsAutoTransferTitle, autoswapSettingsTitle, autoswapTitle).
  • ✅ No @key metadata (descriptions/placeholders) needed updating — only display strings changed.
  • ✅ Indentation fixes (fundExchangeErrorTitleOrdPo404, fundExchangeErrorOrdPo404) align them with the surrounding 2-space style — pure whitespace, no behavior change.

Minor observation (non-blocking): Casing is inconsistent across the keys — autoswapSettingsTitle (line 1462) uses title case "Transferencia Automática" while bitcoinSettingsAutoTransferTitle and autoswapTitle use sentence case "Transferencia automática". This inconsistency pre-existed in the file and was preserved, so it's not introduced by this PR. If you'd like uniform sentence-casing, it could be aligned here, but it's safe to leave as-is.

LGTM. 👍

@ethicnology
ethicnology merged commit 86b95ca into develop Jun 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shorten Spanish label for auto transfer settings

2 participants