chore(l10n): remove dead localization keys from non-en arb files - #2285
Merged
Conversation
Removed 10 keys (and their @metadata) that exist in translation files but not in the app_en.arb template, so no getter is generated and no Dart code references them: - autoswapWarningTriggerAmount, autoswapWarningBaseBalance - homeLegacyStorageWithNoBackupTitle, homeLegacyStorageWithNoBackupDescription - homeLegacyStorageTitle, homeLegacyStorageDescription - legacyStorageWarningBackupNow, legacyStorageWarningLater - errorReportingMigrationSubtitle, transactionSwapOpenWithin24Hours
|
Claude finished @ethicnology's task in 2m 6s —— View job Review: PR #2285 — remove dead localization keys
SummaryLGTM ✅ — This is a safe, correct cleanup. No bugs, security issues, or regressions found. The PR removes 10 keys (plus their
Why this is safe: Flutter's Minor observations (non-blocking):
Nice cleanup. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @bsn21m
Removed 10 keys (and their @metadata) that exist in translation files but not in the app_en.arb template, so no getter is generated and no Dart code references them: