Skip to content

chore: 6.12.0 changelog - #2403

Merged
ethicnology merged 3 commits into
developfrom
changelog-6.12.0
Jul 5, 2026
Merged

chore: 6.12.0 changelog#2403
ethicnology merged 3 commits into
developfrom
changelog-6.12.0

Conversation

@ethicnology

Copy link
Copy Markdown
Member

No description provided.

@ethicnology ethicnology self-assigned this Jul 5, 2026
@claude

claude Bot commented Jul 5, 2026

Copy link
Copy Markdown

Claude finished @ethicnology's task in 5m 15s —— View job


Review: 6.12.0 changelog

  • Gather context (diff vs base, CHANGELOG.md, git history)
  • Verify changelog entries against merge history
  • Post review findings

I cross-checked every PR/issue reference in the new 6.12.0 section against the git merge history. The entries that I could verify all match their commits (e.g. #2402 is merged at the tip of develop, #2199/#2133, #2224/#1544, #2316, #2383, #2389 all check out). A few problems below, ordered by severity. Note: I can't post formal inline review comments (GitHub App limitation), so findings are listed here with line references; I also had no network access to the GitHub API, so items are marked with the evidence they rest on.

Findings

1. CHANGELOG.md:15#2388 is a PR, not the "Rolling Elephant" dev-cycle issue. The header line links issues/2388 as the development-cycle tracking issue, but git history shows Merge pull request #2388 from SatoshiPortal/rolling-elephant-bug-fixes (merged 2026-06-30). Issues and PRs share one number namespace, so #2388 cannot also be the cycle's tracking issue — the link will redirect readers to a bug-fix PR. Lines 41 and 52 use pull/2388 correctly; line 15 needs the real tracking-issue number. Fix this →

2. Missing user-facing change: PR #2337. feat(send): point to frozen coins when balance falls short (#2337) was squash-merged into develop on 2026-06-24 (commit 24432e52b, reachable from this branch). It's a user-facing send-flow improvement tied directly to the headline Coins/freeze feature — when a send fails for insufficient balance, the error now points at frozen coins — but it appears nowhere in the changelog.

3. Gap between 6.11.0 and 6.12.0: hotfix 6.11.1 and its funding fixes are unaccounted for. History (visible on other refs in this checkout) contains Merge pull request #2258 from SatoshiPortal/hotfix/6.11.1 and Merge pull request #2272 from SatoshiPortal/funding-fixes-6110 (commits like "fix: align funding+error handling with bb-exchange", new exchange API error alignment), later folded into develop via #2274. If 6.11.1 shipped, the changelog jumps from 6.11.0 straight to 6.12.0 and silently drops those release notes; if it didn't ship, the #2272 funding fixes are user-facing changes first released in 6.12.0 and are missing from this section. Either way something needs a home. (Shallow CI clone — please double-check against the releases page.)

4. CHANGELOG.md:59 — error-sanitization entry likely misses PRs #2306, #2312, #2313. History shows Merge pull request #2306 from SatoshiPortal/2301-sanitize-pincode-errors, #2312 …refactor-errors-app-unlock, and #2313 …refactor-error-again merged mid-June (this cycle). The entry's PR list stops at the #2328#2346 batch, and its prose also omits PIN code and app unlock from the list of sanitized areas.

5. CHANGELOG.md:52 — miscategorized entry (minor). "Enabled BitBox02 access for all users" sits under Bug Fixes → UI & Layout, but the commit is chore: allow access to bitbox02 for all users — a feature-gate removal, not a UI fix. It would read better merged into the BitBox02 bullet under New Features (line 21).

6. CHANGELOG.md:42 — please verify the #2290 number (informational). The described commits all exist ("swaps status watcher in send now uses drift watch…", "claim-fee relay floor, watcher teardown…"), but I found no Merge pull request #2290 commit in the reachable history. The shallow clone may simply cut it off — just worth a quick confirm that #2290 is the right PR.

Summary

No security issues — the content itself is accurate and well-written where verifiable, and describing the error-sanitization work doesn't expose anything sensitive. The real problems are reference/completeness ones: the dev-cycle link at line 15 points at the wrong artifact (finding 1), one merged user-facing feature is missing (finding 2), and the 6.11.0→6.12.0 jump may drop a hotfix release's notes (finding 3). Findings 4–6 are smaller completeness/placement nits.

 & 6.11.1 section, move BitBox access to features
@ethicnology
ethicnology merged commit dcfdaae into develop Jul 5, 2026
1 check passed
@i5hi
i5hi deleted the changelog-6.12.0 branch July 7, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant