fix(buy): surface order-creation errors and clarify payout wallet vs method - #2532
Draft
BullishNode wants to merge 1 commit into
Draft
fix(buy): surface order-creation errors and clarify payout wallet vs method#2532BullishNode wants to merge 1 commit into
BullishNode wants to merge 1 commit into
Conversation
…method
- Show the network on default wallets in the buy dropdown: Instant
payments (L-BTC on Liquid) / Secure Bitcoin (BTC on Bitcoin chain).
External and custom wallets keep their own names.
- Split the confirm page's Payout method row into Payout wallet and
Payout method, sharing the network phrases with the dropdown.
- Success message now includes what was paid: 'You bought {amount}
with {fiatAmount}' from the order's payin side.
- Below-minimum (and any other) order-creation failures are no longer
silent: the amount screen renders limit errors with the server's
amount and currency, and everything else through a neutral fallback
message. Previously only below-min/above-max variants rendered, and
most server errors never mapped to them, leaving Continue dead.
- Make the createOrder error parsing total via a shared Never-typed
helper across buy, sell, pay and withdraw: an error response can no
longer fall through to the result cast. Parses the server's singular
reason and new plural reasons shapes (API-Orders#859), tolerating
empty and limit-less entries.
- Stop converting fiat limit amounts with btcToSats: a 20 CAD minimum
rendered as 2,000,000,000 sats. Error entities now carry amount and
currency verbatim; the render site formats fiat as fiat.
- Repair broken translations the changed keys touched (zh/fa/th/tr
buyYouBought, zh payout-method and external-wallet strings).
Closes #2515
Closes #2516
Closes #2517
Closes #2518
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
btcToSats(a 20 CAD minimum rendered as 2,000,000,000 sats).Changes
displayLabel/global ARB keys used by 24 other call sites are untouchedNever-typed helper across buy/sell/pay/withdraw; parses the server's singularreasonand new pluralreasonsshapes (SatoshiPortal/API-Orders#865), tolerating empty and limit-less entriesBuyErrorrenders through a neutral fallback message — Continue is never silently deadValidation
10 new datasource parsing tests (all server error shapes incl. empty/mixed/null); analyze + gen-l10n clean across 27 locales; reviewed with a verification pass (wording + zh fixes applied). Full "minimum is X" copy for multi-option rejections additionally needs API-Orders#865 deployed; the app degrades gracefully without it.
Closes #2515
Closes #2516
Closes #2517
Closes #2518