fix(pay): show amount and recipient, and let payment status actually update - #2534
Draft
BullishNode wants to merge 1 commit into
Draft
fix(pay): show amount and recipient, and let payment status actually update#2534BullishNode wants to merge 1 commit into
BullishNode wants to merge 1 commit into
Conversation
…update
- 'Payment in Progress!' now says what is happening: 'The payment of
{fiatAmount} to {recipient} will be sent after your transaction
receives 1 confirmation onchain', with the recipient resolved from
the order (name, then label, then account identifier). Same
treatment on the completed screen, and the details table gains a
Recipient row.
- Once the payin confirms, the copy switches to 'Your transaction is
confirmed. The payment ... is being processed', driven by the
existing 5s poll.
- The success state now carries the post-broadcast order instead of
the stale pre-broadcast snapshot the bloc fetched and discarded.
- Transaction details: pull-to-refresh, and a proper error state with
Retry instead of skeletons that spin forever when the load fails.
- New localization keys instead of editing the old ones, so stale
translations fall back to English rather than silently dropping the
amount and recipient.
Closes #2524
Closes #2525
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Changes
Deliberately minimal per issue discussion: no status-code state machine, no staleness indicators, no refresh-on-focus.
Validation
New bloc test pins the fresh-order emit (fails on old code); analyze clean; pay + transactions suites green; reviewed with a verification pass (watcher-leak fix applied). Merge note: this PR must merge BEFORE the fee-selection PR, which removes event params this branch's screen/test still construct — the fee-selection PR reconciles on rebase.
Closes #2524
Closes #2525