refactor: add Gap to bull_ui and drop gap dependency - #2558
Merged
Conversation
|
Claude finished @wired-pasteque's task in 3m 6s —— View job PR Review — vendoring
|
ethicnology
added a commit
that referenced
this pull request
Aug 4, 2026
Resolutions worth knowing about: - gap -> bull_ui: develop vendored Gap into bull_ui and dropped the `gap` dependency (#2558). The three tor/recoverbull widgets that still imported `package:gap/gap.dart` now import `Gap` from bull_ui. Note that pubspec.yaml auto-merged without conflict, so the dependency was already gone while those imports remained — the compiler, not git, caught it. - connecting_page: took bull_ui's Gap and dropped the `gif` import, which this branch had already removed along with the animation. - recoverbull_repository: develop swapped `package:hex` for `package:convert` (`convert.hex.decode(_normalizeHex(x))`) while this branch changed `externalProxy:` to `endpoint:`. Orthogonal, so both sides kept. - recoverbull_repository_test: git auto-merged this file with no conflict, but develop's new hex-tolerance group still called the pre-branch signature. Ported to the 4-positional-argument `fetchVaultKey` and `endpoint:` stub. - localization: took develop's 27 .arb wholesale, then replayed this branch's 21 Tor keys and its updated torSettingsInfoDescription through tools/arb.dart, so every other key stays byte-for-byte unchanged. Verified per locale: develop's keys untouched, the branch's per-locale translations restored. Ran build-runner (TorSettingsState and SettingsEntity both gained fields), then `make checks` green: analyze, bull-ui-check, fix-check, format-check, and 940 + 21 + 1 + 23 unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the external
gappackage from the project.bull_uinow ships its ownGap(vendored fromgap3.0.1), and every feature sourcesGapthroughbull_uiinstead of importingpackage:gap.