fix: boltz 0.5.2 restore hardening — rescue skipped-swap reporting (6.12.6+206) - #2666
Open
i5hi wants to merge 2 commits into
Open
fix: boltz 0.5.2 restore hardening — rescue skipped-swap reporting (6.12.6+206)#2666i5hi wants to merge 2 commits into
i5hi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal test build for the users failing to claim/refund restored swaps. Based off main (6.12.4+201) so the only delta vs what those users run is the restore fix chain.
What
344a04e(bump-boltz-0.5.2-for-6.12.x): the app's current pin (bd4835c) plus ONLY boltz-dart 0.5.2 (develop6f75525— boltz-dart Recieve Page Address Label Save #56/Unable to change Tx label #57/Addresses In Wallet Settings page should load addresses #58/Updated BackButton in appBar component #59/Recover wallet should support 24 words #60/Make wallet label mandatory on new wallets #61). Deliberately NOT bull_sdk main (a4dd62d, PR Bug when creating unsigned PSBTs #20): that tip also carries the ark.dart removal and lwk's u64→BigInt API change, both compile-breaking on app main and unrelated to this diagnostic build. Develop takes PR Bug when creating unsigned PSBTs #20's pin later together with its ark/lwk state.Restored*Swaps { swaps, skipped }API: datasource wrapper return types, and the fiverescueSwaplookups now search.swapswith a skipped-aware miss handler.swap <id> could not be rebuilt from restore: <reason>instead of the misleading "possibly beyond gap limit", and every skipped swap is logged (SWAP_RESTORE: swap <id> returned by scan but not rebuildable: ...) so user logs show it.What this fixes for the affected users
Claim details required…— boltz-dart Recieve Page Address Label Save #56), which previously blocked rescuing every other swap too.Verification
dart analyze lib test: 0 issues. Full test suite: 499/499.Test protocol on the affected device
SWAP_RESTORE:lines show restored/skipped ids for diagnosis.Note: develop owes main a merge-back of this after the release (along with the existing 6.12.x debt).