feat(core): add an enter key to the mnemonic keyboard - #2699
Merged
Conversation
|
Claude finished @wired-pasteque's task in 3m 8s —— View job Review: Enter key for the mnemonic keyboard
Verdict: LGTM. I found no correctness bugs, security issues, or regressions — only two minor nits. Nice PR: small, well-documented, and the tests cover all four rows of the behavior table (advance on whole word, skip empty, hold on prefix, dismiss on last field). What I checked
Nits (non-blocking)
Notes on process
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focus stayed in the field you'd just finished, so every word cost an extra tap to reach the next one. This adds an
Enterkey that moves focus forward.Screen.Recording.2026-08-20.at.1.52.21.PM.mov