Skip to content

Update patch.diff limit to 100 invoices/payments in rpc #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leesalminen wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update patch.diff limit to 100 invoices/payments in rpc #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions bitcoin-utils/spark-wallet/patch.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,14 @@ index 837dfa9..408f759 100644
, openChan$.map(d => [ '_connectfund', [ d.nodeuri, d.channel_capacity_sat, d.feerate ] ])
, closeChan$.map(d => [ '_close', [ d.peerid, d.chanid ] ])

@@ -90,7 +90,7 @@ exports.makeReq = ({ viewPay$, confPay$, offerPay$, offerRecv$, newInv$, goLogs$
, timer(60000).mapTo( [ '_listpays', [], { bg: true } ])
@@ -87,10 +87,10 @@ exports.makeReq = ({ viewPay$, confPay$, offerPay$, offerRecv$, newInv$, goLogs$
timer(10).mapTo( [ 'getinfo' ] )

// Periodic updates
-, timer(60000).mapTo( [ '_listinvoices' ], { bg: true } ])
-, timer(60000).mapTo( [ '_listpays', [], { bg: true } ])
+, timer(60000).mapTo( [ '_listinvoices', [ { limit: 100 } ], { bg: true } ])
+, timer(60000).mapTo( [ '_listpays', [ { limit: 100 } ], { bg: true } ])
, timer(60000).mapTo( [ 'getinfo', [], { bg: true } ])
, timer(60000).merge(goChan$).throttleTime(2000)
- .mapTo( [ 'listpeers', [], { bg: true } ])
Expand Down Expand Up @@ -482,9 +488,20 @@ index 14b931e..0be3bb4 100644
+export const getPricePerUnit = ({ amount_msat, quantity }) =>
+ Big(amount_msat).div(quantity).toFixed(0)
diff --git a/src/cmd.js b/src/cmd.js
index 9e5f84c..ba55fdf 100644
index 9e5f84c..3f59cf9 100644
--- a/src/cmd.js
+++ b/src/cmd.js
@@ -17,8 +17,8 @@ const debug = require('debug')('spark:cmd')
, which = [ 'invoices', 'payments' ]
// @XXX invoices that get paid and payments that succeed no longer show up in these commands
// this may result in incorrect accounting and non-idempotent results from commands
-, _listinvoices: ln => ln.listinvoices().then(formatInvoices)
-, _listpays: ln => ln.call('listpays').then(r => r.pays.map(pay => ({ ...pay, msatoshi_sent: pay.amount_sent_msat, created_at: +(pay.created_at||0) }))).then(formatPays)
+, _listinvoices: ln => ln.listinvoices({ limit: 100 }).then(formatInvoices)
+, _listpays: ln => ln.call('listpays', { limit: 100 }).then(r => r.pays.map(pay => ({ ...pay, msatoshi_sent: pay.amount_sent_msat, created_at: +(pay.created_at||0) }))).then(formatPays)

export const commands = {
// Queries
@@ -82,7 +82,7 @@ export const commands = {
}

Expand Down