[STORY-2981] Use Scalingo lua-linter and lua-tests actions#13
[STORY-2981] Use Scalingo lua-linter and lua-tests actions#13
Conversation
briceamen
force-pushed
the
feat/STORY-2981/lua-actions
branch
from
364136f to
5d203d1
Compare
EtienneM
left a comment
EtienneM
left a comment
There was a problem hiding this comment.
A couple of questions, but already approving.
| sudo chmod +x /usr/local/bin/resty-busted | ||
|
|
||
| # Export LUA paths (include lib directory for the rollbar module) | ||
| echo "LUA_PATH=${GITHUB_WORKSPACE}/lib/?.lua;$(luarocks --tree "${LUAROCKS_TREE}" path --lr-path)" >> "${GITHUB_ENV}" |
There was a problem hiding this comment.
I just thought of something. Is it really useful to use LUA_PATH like here:
https://github.com/Scalingo/actions/blob/main/lua-linter/scripts/run-lua-lint.sh#L8-L11
And there:
https://github.com/Scalingo/actions/blob/main/lua-linter/action.yml#L11-L18
?
I mean, from what I understand of GitHub Action, the fact that you write to GITHUB_ENV makes LUA_PATH configured anyway in the action environment. No need to do anything else. WDYT? Could you quickly try to remove the LUA_PATH things in the actions repository?
There was a problem hiding this comment.
question: shouldn't we update something in the dev env to also use this script to execute the specs?
briceamen
force-pushed
the
feat/STORY-2981/lua-actions
branch
from
57f24fe to
8cac385
Compare
2 participants
This PR adds CI workflow using Scalingo lua-linter and lua-tests GitHub actions.