Merge branch 'master' into qqy/mirk_for_mp

Author: ErikQQY

Project.toml

@@ -60,7 +60,7 @@ Random = "1.10"
 ReTestItems = "1.29"
 RecursiveArrayTools = "3.31.2"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 Sparspak = "0.3.11"
 StaticArrays = "1.9.8"
 Test = "1.10"

lib/BoundaryValueDiffEqAscher/Project.toml

@@ -36,7 +36,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.130.0"
+SciMLBase = "2.152.1"
 Setfield = "1.1.1"
 StaticArrays = "1.9.8"
 Test = "1.10"

lib/BoundaryValueDiffEqCore/Project.toml

@@ -13,7 +13,6 @@ ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
 Integrals = "de52edbc-65ea-441a-8357-d3a637375a31"
 LineSearch = "87fe0de2-c867-4266-b59a-2f0a94fc965b"
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
-Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
 NonlinearSolveBase = "be0214bd-f91f-a760-ac4e-3421ce2b2da0"
 NonlinearSolveFirstOrder = "5959db7a-ea39-4486-b5fe-2dd0bf03d60d"
 OptimizationBase = "bca83a33-5cc9-4baa-983d-23429ab6bcbb"
@@ -40,14 +39,13 @@ Integrals = "4.7.1, 5"
 InteractiveUtils = "<0.0.1, 1"
 LineSearch = "0.1.4"
 LinearAlgebra = "1.10"
-Logging = "1.10"
 NonlinearSolveBase = "2.11.2"
 NonlinearSolveFirstOrder = "1.2, 2"
 OptimizationBase = "3.2.0, 4, 5"
-PreallocationTools = "0.4, 1"
+PreallocationTools = "1.2"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 SciMLLogging = "1.8.0"
 SciMLStructures = "1.7.0"
 Setfield = "1"

lib/BoundaryValueDiffEqCore/src/BoundaryValueDiffEqCore.jl

@@ -8,7 +8,6 @@ using ConcreteStructs: @concrete
 using DiffEqBase: DiffEqBase, solve
 using ForwardDiff: ForwardDiff, pickchunksize
 using Integrals: Integrals, IntegralProblem
-using Logging: Logging
 using LinearAlgebra
 using LineSearch: BackTracking
 using NonlinearSolveFirstOrder: NonlinearSolvePolyAlgorithm

lib/BoundaryValueDiffEqCore/src/types.jl

@@ -171,19 +171,15 @@ end
 end
 
 function __maybe_allocate_diffcache(x, chunksize, jac_alg)
-    return __needs_diffcache(jac_alg) ? DiffCache(x, chunksize) : x
+    return __needs_diffcache(jac_alg) ?
+        DiffCache(x, chunksize; warn_on_resize = false) : x
 end
-__maybe_allocate_diffcache(x::DiffCache, chunksize) = DiffCache(zero(x.du), chunksize)
-
-## get_tmp shows a warning as it should on cache expansion, this behavior however is
-## expected for adaptive BVP solvers so we write our own `get_tmp` and drop the warning logs
-
-@inline function get_tmp(dc, u)
-    return Logging.with_logger(Logging.NullLogger()) do
-        PreallocationTools.get_tmp(dc, u)
-    end
+function __maybe_allocate_diffcache(x::DiffCache, chunksize)
+    return DiffCache(zero(x.du), chunksize; warn_on_resize = false)
 end
 
+@inline get_tmp(dc, u) = dc
+
 # DiffCache
 struct DiffCacheNeeded end
 struct NoDiffCacheNeeded end

lib/BoundaryValueDiffEqFIRK/Project.toml

@@ -53,7 +53,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 SciMLStructures = "1.7.0"
 Setfield = "1.1.1"
 SparseArrays = "1.10"

lib/BoundaryValueDiffEqMIRK/Project.toml

@@ -53,7 +53,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.138.0"
+SciMLBase = "2.152.1"
 SciMLStructures = "1.7.0"
 Setfield = "1.1.1"
 SparseArrays = "1.10"

lib/BoundaryValueDiffEqMIRKN/Project.toml

@@ -48,7 +48,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.130.0"
+SciMLBase = "2.152.1"
 Setfield = "1.1.1"
 SparseArrays = "1.10"
 StaticArrays = "1.9.8"

lib/BoundaryValueDiffEqShooting/Project.toml

@@ -51,7 +51,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.27.0"
 Reexport = "1.2"
-SciMLBase = "2.130.0"
+SciMLBase = "2.152.1"
 Setfield = "1.1.1"
 SparseArrays = "1.10"
 StaticArrays = "1.9.8"

test/misc/type_stability_tests.jl

@@ -1,5 +1,5 @@
 @testitem "Type Stability" begin
-    using LinearAlgebra, BoundaryValueDiffEq, OrdinaryDiffEqTsit5
+    using LinearAlgebra, BoundaryValueDiffEq, OrdinaryDiffEqTsit5, SciMLBase
 
     f(u, p, t) = [p[1] * u[1] - p[2] * u[1] * u[2], p[3] * u[1] * u[2] - p[4] * u[2]]
     function f!(du, u, p, t)
@@ -24,10 +24,22 @@
 
     jac_alg = BVPJacobianAlgorithm(AutoForwardDiff(; chunksize = 2))
 
+    # BVProblem constructor type stability (issue #454)
+    # Explicit {iip} constructors should be type-stable
+    @testset "BVProblem Constructor" begin
+        @inferred BVProblem{true}(f!, bc!, u0, tspan, p)
+        @inferred BVProblem{false}(f, bc, u0, tspan, p)
+
+        # __init should be type-stable with properly typed problems
+        prob_iip = BVProblem{true}(f!, bc!, u0, tspan, p)
+        @inferred SciMLBase.__init(prob_iip, MIRK5(; jac_alg); dt = 0.2)
+    end
+
     # Multi-Point BVP
+    # nlls is properly inferred as false for StandardBVProblem without bcresid_prototype
     @testset "Multi-Point BVP" begin
-        mpbvp_iip = BVProblem(f!, bc!, u0, tspan, p; nlls = Val(false))
-        mpbvp_oop = BVProblem(f, bc, u0, tspan, p; nlls = Val(false))
+        mpbvp_iip = BVProblem(f!, bc!, u0, tspan, p)
+        mpbvp_oop = BVProblem(f, bc, u0, tspan, p)
 
         # Shooting methods have deep type instability from NonlinearSolve/OrdinaryDiffEq
         # that requires further investigation. The solvers work correctly but return type