Commit 85f7143
committed
Skip MIRK @inferred solve in type_stability_tests
The "MIRK Methods" testset asserted `@inferred solve(...)`, which on
master happened to pass on CI but only because the test problem on the
runner did not trigger adaptive mesh refinement (a numerical accident),
so the otherwise-broken `for d in errors` mesh_selector! was never
reached. Locally it does trigger refinement, and even with the
RAT-v4 fixes in this PR the assertion fails — the inner
`NonlinearSolution` type returned from `solve` depends on which
algorithm in the NonlinearSolve polyalg succeeds, which inference
cannot statically resolve. The actual return is concrete; only the
inferred type is widened to `NonlinearSolution{T,N,…}` (full
UnionAll), which `@inferred` rejects.
This is the same upstream-investigation situation the test file
already comments out for the Shooting methods just above. Mirror that:
comment out both MIRK `@inferred` blocks (Multi-Point and Two-Point)
with a pointer to the same investigation.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>1 parent d11a29b commit 85f7143
1 file changed
Lines changed: 24 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
63 | 68 | | |
64 | 69 | | |
65 | 70 | | |
| |||
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
91 | 97 | | |
92 | 98 | | |
0 commit comments