Move BVP default solver from DifferentialEquations.jl to BoundaryValueDiffEq.jl - #370
Closed
ChrisRackauckas wants to merge 3 commits into
Closed
Move BVP default solver from DifferentialEquations.jl to BoundaryValueDiffEq.jl#370ChrisRackauckas wants to merge 3 commits into
ChrisRackauckas wants to merge 3 commits into
Conversation
…eDiffEq.jl Matches https://github.com/SciML/DifferentialEquations.jl/blob/master/src/bvp_default_alg.jl. This definitely isn't what the final form should be, but it's a step towards splitting DifferentialEquations.jl so we should follow up later on this. I think we should in this day and age make one of the FIRKs the default, but without autodiff requirements? Or auto-autodiff.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -0,0 +1,24 @@ | |||
| @testitem "Default Solvers" begin | |||
| using BoundaryValueDiffEq, Test | |||
|
|
|||
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| du[1] = v | ||
| du[2] = -x | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| resid[1] = sol[1][1] | ||
| resid[2] = sol[end][1] - 1 | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| resid_f = Array{Float64}(undef, 2) | ||
| sol = solve(bvp, Shooting(Tsit5())) | ||
| sol2 = solve(bvp) | ||
|
|
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Contributor
Benchmark ResultsClick to check benchmark results
|
Merged
3 tasks
ChrisRackauckas-Claude
pushed a commit
to ChrisRackauckas-Claude/BoundaryValueDiffEq.jl
that referenced
this pull request
Aug 10, 2025
…eDiffEq.jl - Add default `__init` and `__solve` methods for BVProblem - Use Shooting(Tsit5()) as the default solver algorithm - Add OrdinaryDiffEqTsit5 as a dependency - Update Aqua tests to allow type-piracy for BVProblem - Add test for default solver functionality This follows the pattern from PR SciML#370 but targets master branch and properly handles the type-piracy in Aqua tests. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches https://github.com/SciML/DifferentialEquations.jl/blob/master/src/bvp_default_alg.jl. This definitely isn't what the final form should be, but it's a step towards splitting DifferentialEquations.jl so we should follow up later on this. I think we should in this day and age make one of the FIRKs the default, but without autodiff requirements? Or auto-autodiff.