Skip to content

style: apply Runic v1.7.0 formatting - #502

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:run-runic-formatting
Jun 7, 2026
Merged

style: apply Runic v1.7.0 formatting#502
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:run-runic-formatting

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Summary

The Runic Format Check (CI format-check job, which uses SciML/.github runic.yml@v1fredrikekre/runic-action@v1 = Runic v1.7.0) was failing because some code was not conformant to that exact Runic version.

This PR fixes that by running Runic v1.7.0 in-place over the whole repo (all tracked .jl files, including lib/ sublibraries) and committing the result.

Details

  • Pure formatting only. No logic changes, no changes to non-.jl files, no CI/Project.toml changes.
  • Only one file actually drifted: lib/BoundaryValueDiffEqMIRK/src/mirk.jl (re-indentation of a multi-line trailing comment in a struct field block).
  • Verified afterwards that a Runic v1.7.0 --check pass reports no remaining diffs across all 110 tracked .jl files.

This is intentionally a separate, self-contained formatting PR so it can be reviewed and merged independently.


Please ignore this PR until reviewed by @ChrisRackauckas.

🤖 Generated with Claude Code

Pure formatting changes to make the Runic Format Check pass. The CI
runs runic-action@v1 (Runic v1.7.0); this commit reformats the repo
with that exact version. No logic changes.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1.11)

Time benchmarks
master 00ca4e3... master / 00ca4e3...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.588 ± 0.01 s 0.576 ± 0.01 s 1.02 ± 0.026
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 12.5 ± 1.1 ms 12 ± 0.86 ms 1.04 ± 0.12
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 2.87 ± 0.52 ms 2.72 ± 0.42 ms 1.05 ± 0.25
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 3.15 ± 0.28 ms 3.17 ± 0.38 ms 0.992 ± 0.15
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.55 ± 0.21 ms 1.58 ± 0.34 ms 0.979 ± 0.25
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.75 ± 0.37 ms 1.76 ± 0.5 ms 0.992 ± 0.35
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.44 ± 1.2 ms 3.38 ± 1.2 ms 1.02 ± 0.51
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.0496 ± 0.017 s 0.0481 ± 0.016 s 1.03 ± 0.51
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.0929 ± 0.022 s 0.0626 ± 0.0096 s 1.48 ± 0.42
Simple Pendulum/IIP/Shooting(Tsit5()) 0.189 ± 0.097 ms 0.191 ± 0.1 ms 0.986 ± 0.72
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.877 ± 0.049 s 0.826 ± 0.024 s 1.06 ± 0.066
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 20 ± 8.8 ms 19.9 ± 9.5 ms 1 ± 0.65
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 4.24 ± 1.3 ms 4.22 ± 0.86 ms 1.01 ± 0.38
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 4.28 ± 1 ms 4.09 ± 1.1 ms 1.05 ± 0.38
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 2.05 ± 0.55 ms 2.38 ± 0.68 ms 0.86 ± 0.34
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 4.26 ± 3.9 ms 3.49 ± 2.8 ms 1.22 ± 1.5
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 11.7 ± 11 ms 7.5 ± 7.6 ms 1.56 ± 2.1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.109 ± 0.022 s 0.127 ± 0.033 s 0.852 ± 0.28
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.185 ± 0.055 s 0.205 ± 0.057 s 0.905 ± 0.37
Simple Pendulum/OOP/Shooting(Tsit5()) 0.782 ± 0.77 ms 0.596 ± 0.19 ms 1.31 ± 1.4
time_to_load 7.84 ± 0.13 s 7.49 ± 0.22 s 1.05 ± 0.035
Memory benchmarks
master 00ca4e3... master / 00ca4e3...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 0.389 M allocs: 0.0442 GB 0.389 M allocs: 0.0442 GB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 0.0436 M allocs: 4.85 MB 0.0436 M allocs: 4.85 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 15.7 k allocs: 1.63 MB 15.7 k allocs: 1.63 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 22.1 k allocs: 2.02 MB 22.1 k allocs: 2.02 MB 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 12.8 k allocs: 1.04 MB 12.8 k allocs: 1.04 MB 1
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 25.4 k allocs: 1.82 MB 25.4 k allocs: 1.82 MB 1
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 0.0488 M allocs: 3.36 MB 0.0488 M allocs: 3.36 MB 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.552 M allocs: 0.0534 GB 0.552 M allocs: 0.0534 GB 1
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.832 M allocs: 0.0777 GB 0.832 M allocs: 0.0777 GB 1
Simple Pendulum/IIP/Shooting(Tsit5()) 4.62 k allocs: 0.223 MB 4.62 k allocs: 0.223 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.89 M allocs: 0.984 GB 0.89 M allocs: 0.984 GB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 0.0932 M allocs: 24.7 MB 0.0932 M allocs: 24.7 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 0.0324 M allocs: 3.94 MB 0.0324 M allocs: 3.94 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 0.045 M allocs: 4.97 MB 0.045 M allocs: 4.97 MB 1
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 25.3 k allocs: 2.16 MB 25.3 k allocs: 2.16 MB 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 0.142 M allocs: 10.2 MB 0.142 M allocs: 10.2 MB 1
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 0.265 M allocs: 18.7 MB 0.265 M allocs: 18.7 MB 1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 2.52 M allocs: 0.279 GB 2.52 M allocs: 0.279 GB 1
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 3.82 M allocs: 0.404 GB 3.82 M allocs: 0.404 GB 1
Simple Pendulum/OOP/Shooting(Tsit5()) 0.0373 M allocs: 1.69 MB 0.0373 M allocs: 1.69 MB 1
time_to_load 0.161 k allocs: 11.4 kB 0.161 k allocs: 11.4 kB 1

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review June 7, 2026 08:17
@ChrisRackauckas
ChrisRackauckas merged commit 00e091c into SciML:master Jun 7, 2026
6 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants