Import Tsit5 in default_solvers test - #510
Merged
ChrisRackauckas merged 1 commit intoJun 10, 2026
Merged
Conversation
test/misc/default_solvers.jl references Tsit5, but BoundaryValueDiffEq does not export it, so the file fails with UndefVarError(:Tsit5) whenever it actually runs. The old ReTestItems-based CI never collected this file (13 test items, none of them Default Solvers), so the latent error only surfaced after SciML#505 added the file to the Misc group: it currently fails in the Downgrade workflow, and in the Misc group it is masked only because the BigFloat safetestset aborts the run first. OrdinaryDiffEqTsit5 is already a test-target dependency. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/misc/default_solvers.jlusesTsit5but only doesusing BoundaryValueDiffEq, which does not export it (verified:isdefined(Main, :Tsit5)isfalseafterusing BoundaryValueDiffEq). The file therefore fails withUndefVarError: Tsit5 not definedwhenever it actually executes.Why this was never seen before: the old ReTestItems-based root CI never collected this file — the last green master run (9665882) executed 13 test items and "Default Solvers" was not among them. #505 added the file to the
Miscgroup, after which:UndefVarError(run 27135552367, after the BigFloat tests pass there with old deps);Fix:
using OrdinaryDiffEqTsit5: Tsit5inside the testset.OrdinaryDiffEqTsit5is already in the test target of the root Project.toml.Verification
Ran the patched file locally on Julia 1.12.6 against a clean master checkout:
Runic check passes on the changed file.
This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code