Fix MIRK extrema boundary conditions under AD - #542
Fix MIRK extrema boundary conditions under AD#542ChrisRackauckas-Claude wants to merge 5 commits into
Conversation
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
|
Update pushed in c306f64. Additional local verification for the Mooncake Julia-pre failure: |
|
Final-state verification after the variable rename commit |
|
Downstream audit replay for head I ran the exact current ModelingToolkitBase Observed terminal summary: The two failures are the cost-function compilation checks evaluating This result is relevant to the caller-workflow correction in #563: that PR points CI at the right moved test group, and the remaining red result is genuine source/integration behavior rather than a workflow startup failure or no-op. |
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
4ef52d1 to
3ed990d
Compare
|
Rebased this branch onto current PR-specific validation:
The broader current-dependency Core run ended at 195 passed, 2 failed, and 1 errored. All three outcomes are independently reproduced on untouched current
No test was skipped, disabled, silenced, or loosened. The branch changes themselves remain the original five focused commits. |
|
CI classification for rebased head
No additional PR-specific failure is exposed by this run. |
Ignore this PR until reviewed by @ChrisRackauckas.
Summary
maxsol/minsol, viaBoundaryValueDiffEqCore.nodual_valuerather than direct MIRK access to ForwardDiff internals.maxsol/minsolboundary conditions.Local Verification
maxsol/minsolMIRK4 reproducer under Julia 1.10 ->SciMLBase.successful_retcode(extrema_sol) = truemaxsol/minsolMIRK4 reproducer under Julia 1.12 ->SciMLBase.successful_retcode(extrema_sol) = trueOptimizationIpopt: bounded constraint path ->SciMLBase.successful_retcode(sol1) = true; no-user-bounds optimization path ->SciMLBase.successful_retcode(sol2) = trueBOUNDARYVALUEDIFFEQ_TEST_GROUP=QA timeout 3600 julia +1.10 --project=lib/BoundaryValueDiffEqMIRK -e 'using Pkg; Pkg.test()'-> Quality Assurance 15/15 passedgit diff --checkRunic.main(["-c", "-d", "."])passed under Julia 1.12CI Status on
6614a935uppercase(::Char)issue tracked in MIRK AD Julia pre fails with Mooncake uppercase(::Char) during matvec differentiation #543.