Handle FIRK expanded AD matvec fallbacks - #557
Draft
ChrisRackauckas-Claude wants to merge 4 commits into
Draft
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
fix-firk-pre-enzyme-fallback-clean
branch
from
July 11, 2026 21:02
a51bd47 to
344016e
Compare
Contributor
Benchmark Results (Julia v1.11)Time benchmarks
Memory benchmarks
|
ChrisRackauckas-Claude
force-pushed
the
fix-firk-pre-enzyme-fallback-clean
branch
from
July 11, 2026 22:02
344016e to
c1c3376
Compare
ChrisRackauckas-Claude
force-pushed
the
fix-firk-pre-enzyme-fallback-clean
branch
from
July 12, 2026 00:26
c1c3376 to
0f7b9f2
Compare
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
fix-firk-pre-enzyme-fallback-clean
branch
from
July 12, 2026 01:42
0f7b9f2 to
c72455d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be ignored until reviewed by @ChrisRackauckas.
Stacked on #552. Until #552 is merged, GitHub's PR diff will include those prerequisite commits; the new change here is the top commit
c72455db.Summary
AutoForwardDiff, while leaving standard-problem BC AD modes intact.promote_type, avoidingBigFloat/SparseConnectivityTracer.Dualpromotion ambiguity in Misc tests.Fixes #554.
Local verification
Targeted NESTED LobattoIIIc4 convergence repro on Julia 1.12.6 after keeping Core matvecs on BLAS:
Full FIRK AD test group on Julia 1.12.6:
Full root Misc test group on Julia 1.10.11 after the product-type fix:
Fresh-resolved targeted multipoint Enzyme repros on Julia 1.13.0-rc1 after the product-type fix:
Formatting/checks: