Skip to content

fix: enable unscalarized array observed without individual observed elements #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AayushSabharwal wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

fix: enable unscalarized array observed without individual observed elements #4451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/ModelingToolkitBase/src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1243,9 +1243,10 @@ function observed_equations_used_by(
obsidxs = BitSet()
for sym in involved_vars
sym in available_vars && continue
arrsym = iscall(sym) && operation(sym) === getindex ? arguments(sym)[1] : nothing
arrsym = split_indexed_var(sym)[1]
idx = @something(
get(obsvar_to_idx, sym, nothing),
get(obsvar_to_idx, arrsym, nothing),
Some(nothing)
)
idx === nothing && continue
Expand Down
6 changes: 6 additions & 0 deletions lib/ModelingToolkitBase/test/code_generation.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,3 +151,9 @@ end
ps = MTKParameters(sys, nothing)
@test fn([1.0], ps, 1.5) ≈ 4.0
end

@testset "Non-scalarized array observed without individual elements being unknowns/observables" begin
@variables x(t)[1:3] y(t)
@mtkcomplete sys = System([D(y) ~ 2y + sum(x)], t, [y], []; observed = [x ~ [y, y + 1, y + 2]])
@test ModelingToolkitBase.observed_equations_used_by(sys, [x[1]]) == [1]
end
Loading