Skip to content

Commit 514627d

Browse files
jClugstorclaude
andcommitted
Drop stale undefined_exports broken marker in OptimizationManopt QA
Aqua now reports "Unexpected Pass" for OptimizationManopt's undefined_exports check: the `solve!` reexport clash that motivated `broken = true` no longer produces an undefined export, so the broken marker errors the test. Remove it and let the check run normally. Verified the other libs with the same marker are still genuinely broken and keep theirs: OptimizationNOMAD (`OptimizationNOMAD.solve` is undefined), plus OptimizationMadNLP/OptimizationMetaheuristics (their QA jobs pass with the marker in place). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 4372e2c commit 514627d

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

  • lib/OptimizationManopt/test/qa

lib/OptimizationManopt/test/qa/qa.jl

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,10 @@ using OptimizationManopt, Aqua, JET
22
using Test
33

44
@testset "Aqua" begin
5-
# `@reexport using Manopt` exports `solve!`, which clashes with SciMLBase's `solve!`
6-
# brought in transitively via OptimizationBase. The clash leaves OptimizationManopt's
7-
# `solve!` export pointing at neither binding; mark broken until the reexport is
8-
# restructured.
95
# Manifolds is declared because the curvature analysis path may pull it in,
106
# but no symbol from it is currently used in src — ignore it for now.
117
Aqua.test_all(
128
OptimizationManopt;
13-
undefined_exports = (; broken = true),
149
stale_deps = (; ignore = [:Manifolds])
1510
)
1611
end

0 commit comments

Comments
 (0)