Skip missing_second_order_ad when analytical second-order derivatives are supplied - #1285
Closed
niy-ati wants to merge 1 commit into
Closed
Skip missing_second_order_ad when analytical second-order derivatives are supplied#1285niy-ati wants to merge 1 commit into
niy-ati wants to merge 1 commit into
Conversation
… are supplied. The cache warning only inspected adtype, so OptimizationFunction(..., hess=...) with NoAD still emitted a false positive even though instantiate_function uses the user Hessian and NoAD does not build a SecondOrder fallback. Gate the warning on missing hess/fgh/hv/cons_h/lag_h. Fixes SciML#1240.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizationCacheemittedmissing_second_order_adwhenever a Hessian-requiring optimizer was used without aSecondOrderAD type, even ifOptimizationFunctionalready supplied analyticalhess/fgh/hv(orcons_h/lag_h).instantiate_function/ DI paths, which use user second-order callbacks when present, andgenerate_adtype(NoAD), which does not build aSecondOrderfallback.Fixes #1240
Test plan
second_order_warning_test.jl: analyticalhess+NoAD→ no warn; missing hess → warnOptimizationBasetests