Skip to content

Fix DiffEqDevTools resolver + common QA regressions post-v7 #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 7 commits into from
Apr 23, 2026
Merged

Fix DiffEqDevTools resolver + common QA regressions post-v7 #3512

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b6bfa09
Fix DiffEqDevTools resolver + common QA regressions post-v7
ChrisRackauckas Apr 23, 2026
2549e62
Revert BVP test removal in DiffEqDevTools
ChrisRackauckas Apr 23, 2026
35bb341
Merge remote-tracking branch 'origin/master' into fix-diffeqdevtools-…
ChrisRackauckas Apr 23, 2026
1065bdf
Merge remote-tracking branch 'origin/master' into fix-diffeqdevtools-…
ChrisRackauckas Apr 23, 2026
b819912
Merge remote-tracking branch 'origin/master' into fix-diffeqdevtools-…
ChrisRackauckas Apr 23, 2026
8dd8986
Drop dynamic-broken wrapper on ABM allocation tests
ChrisRackauckas Apr 23, 2026
ecb259e
Apply suggestion from @ChrisRackauckas
ChrisRackauckas Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/src/explicit/LowStorageRK.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,6 @@ RDPK3Sp49
RDPK3SpFSAL49
RDPK3Sp510
RDPK3SpFSAL510
HSLDDRK64
NDBLSRK134
SHLDDRK_2N
SHLDDRK52
Expand Down
4 changes: 2 additions & 2 deletions lib/OrdinaryDiffEqAdamsBashforthMoulton/test/qa/allocation_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ using Test
(typeof(integrator), typeof(cache))
)

@test length(allocs) == 0 broken = true
@test length(allocs) == 0

if length(allocs) > 0
println(
Expand Down Expand Up @@ -66,7 +66,7 @@ using Test
(typeof(integrator), typeof(cache))
)

@test length(allocs) == 0 broken = true
@test length(allocs) == 0

if length(allocs) > 0
println(
Expand Down
5 changes: 4 additions & 1 deletion lib/OrdinaryDiffEqLowStorageRK/test/qa/allocation_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ using Test

# 2N low-storage methods
# RDPK3 family excluded: PID controller init bug (MVector{3} from Bool flags)
# HSLDDRK64 was removed from OrdinaryDiffEqLowStorageRK (it is not
# exported and no struct of that name is defined in the package); test
# against the exported solvers only.
Comment thread
ChrisRackauckas marked this conversation as resolved.
Outdated
lsrk_2n_solvers = [
ORK256(), CarpenterKennedy2N54(), SHLDDRK64(), HSLDDRK64(),
ORK256(), CarpenterKennedy2N54(), SHLDDRK64(),
DGLDDRK73_C(), DGLDDRK84_C(), DGLDDRK84_F(),
NDBLSRK124(), NDBLSRK134(), NDBLSRK144(),
CFRLDDRK64(), TSLDDRK74(),
Expand Down
17 changes: 14 additions & 3 deletions lib/OrdinaryDiffEqNonlinearSolve/test/qa/jet.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import OrdinaryDiffEqNonlinearSolve
using OrdinaryDiffEqRosenbrock, OrdinaryDiffEqBDF
using LinearAlgebra: Diagonal
using ADTypes
using SciMLBase: FullSpecialize
using JET

@testset "JET Tests" begin
Expand All @@ -23,8 +24,16 @@ using JET
end
dae_func = ODEFunction(dae, mass_matrix = Diagonal([1.0, 0.0]))
dae_oop_func = ODEFunction(dae_oop, mass_matrix = Diagonal([1.0, 0.0]))
mm_prob = ODEProblem(dae_func, [0.0, 1.0], (0.0, 1.0))
mm_oop_prob = ODEProblem(dae_oop_func, [0.0, 1.0], (0.0, 1.0))
# Use `FullSpecialize` so that `ODEProblem`'s default
# `FunctionWrapperSpecialize` doesn't introduce a `FunctionWrappersWrapper`
# in the call chain — JET flags runtime dispatch inside
# `FunctionWrappers.reinit_wrapper` which is not part of the solver's
# own type-stability surface and is an upstream limitation of
# FunctionWrappers' opaque `objptr` field.
mm_prob = ODEProblem{true, FullSpecialize}(dae_func, [0.0, 1.0], (0.0, 1.0))
mm_oop_prob = ODEProblem{false, FullSpecialize}(
dae_oop_func, [0.0, 1.0], (0.0, 1.0)
)
ad = AutoForwardDiff(chunksize = 2)

# DAE problem for DAE solvers
Expand All @@ -33,7 +42,9 @@ using JET
end
u0 = [1.0]
du0 = [-1.0]
dae_prob = DAEProblem(simple_dae!, du0, u0, (0.0, 1.0))
dae_prob = DAEProblem{true, FullSpecialize}(
simple_dae!, du0, u0, (0.0, 1.0)
)


# Solvers which are not fully type-stable for initialization
Expand Down
7 changes: 1 addition & 6 deletions lib/OrdinaryDiffEqRosenbrock/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,18 @@ LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"
MuladdMacro = "46d2c3a1-f734-5fdb-9937-b9b9aeba4221"
OrdinaryDiffEqBDF = "6ad6398a-0878-4a85-9266-38940aa047c8"
OrdinaryDiffEqCore = "bbf590c4-e513-4bbe-9b18-05decba2e5d8"
OrdinaryDiffEqDifferentiation = "4302a76b-040a-498a-8c04-15b101fed76b"
OrdinaryDiffEqRosenbrockTableaus = "b4bd8bb3-f80f-41d2-9b21-73a655b304b9"
OrdinaryDiffEqNonlinearSolve = "127b3ac7-2247-4354-8eb6-78cf4e7c58e8"
PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a"
Preferences = "21216c6a-2e73-6563-6e65-726566657250"
RecursiveArrayTools = "731186ca-8d62-57ce-b412-fbd966d074cd"
Reexport = "189a3867-3050-52da-a836-e630ba90ab69"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462"

[sources]
DiffEqBase = {path = "../DiffEqBase"}
DiffEqDevTools = {path = "../DiffEqDevTools"}
OrdinaryDiffEqBDF = {path = "../OrdinaryDiffEqBDF"}
OrdinaryDiffEqCore = {path = "../OrdinaryDiffEqCore"}
OrdinaryDiffEqDifferentiation = {path = "../OrdinaryDiffEqDifferentiation"}
OrdinaryDiffEqNonlinearSolve = {path = "../OrdinaryDiffEqNonlinearSolve"}
Expand All @@ -49,7 +45,6 @@ LinearSolve = "3.46"
MacroTools = "0.5.6"
MuladdMacro = "0.2"
ODEProblemLibrary = "1"
OrdinaryDiffEqBDF = "1.26"
OrdinaryDiffEqCore = "4"
OrdinaryDiffEqDifferentiation = "2"
OrdinaryDiffEqNonlinearSolve = "1.16.0"
Expand All @@ -60,7 +55,7 @@ Preferences = "1.4"
Random = "<0.0.1, 1"
RecursiveArrayTools = "4"
Reexport = "1.2"
SafeTestsets = "0.1.0"
SafeTestsets = "0.1"
SciMLBase = "3"
Test = "<0.0.1, 1"
julia = "1.10"
Expand Down
Loading