Skip to content

Fix Rosenbrock convergence-order test flakiness (Rodas6P dts + Rodas5P+Krylov tol) #3528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 2 commits into from
Apr 23, 2026
Merged

Fix Rosenbrock convergence-order test flakiness (Rodas6P dts + Rodas5P+Krylov tol) #3528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cab06ff
Fix Rosenbrock test roundoff / Krylov tolerance issues
ChrisRackauckas Apr 23, 2026
5da9045
Apply suggestion from @ChrisRackauckas
ChrisRackauckas Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/OrdinaryDiffEqRosenbrock/test/ode_rosenbrock_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,8 @@ end

prob = prob_ode_linear

sim = test_convergence(dts, prob, Rodas6P(), dense_errors = true)
rodas6p_dts = (1 / 2) .^ (5:-1:2)
sim = test_convergence(rodas6p_dts, prob, Rodas6P(), dense_errors = true)
#@test sim.𝒪est[:final]≈5 atol=testTol #-- observed order > 6
@test sim.𝒪est[:L2] ≈ 6 atol = testTol

Expand All @@ -217,7 +218,7 @@ end

prob = prob_ode_2Dlinear

sim = test_convergence(dts, prob, Rodas6P(), dense_errors = true)
sim = test_convergence(rodas6p_dts, prob, Rodas6P(), dense_errors = true)
#@test sim.𝒪est[:final]≈5 atol=testTol #-- observed order > 6
@test sim.𝒪est[:L2] ≈ 6 atol = testTol

Expand Down Expand Up @@ -256,6 +257,8 @@ end
#@test sim.𝒪est[:final]≈5 atol=testTol #-- observed order > 6
@test sim.𝒪est[:L2] ≈ 5 atol = testTol

# Krylov linear solvers need tight tolerance for the outer-method
# convergence order to surface; LinearSolve now respects reltol/abstol.
sim = test_convergence(
dts, prob,
Rodas5P(
Expand All @@ -264,7 +267,8 @@ end
),
linsolve = LinearSolve.KrylovJL()
),
dense_errors = true
dense_errors = true,
reltol = 1.0e-14, abstol = 1.0e-14
)
#@test sim.𝒪est[:final]≈5 atol=testTol #-- observed order > 6
@test sim.𝒪est[:L2] ≈ 5 atol = testTol
Expand All @@ -277,7 +281,8 @@ end
),
linsolve = LinearSolve.KrylovJL_GMRES()
),
dense_errors = true
dense_errors = true,
reltol = 1.0e-14, abstol = 1.0e-14
)
#@test sim.𝒪est[:final]≈5 atol=testTol #-- observed order > 6
@test sim.𝒪est[:L2] ≈ 5 atol = testTol
Expand Down
Loading