Set error=false chunk default to fail builds on uncaught errors - #1512
Merged
ChrisRackauckas merged 1 commit intoMar 21, 2026
Merged
Conversation
…rors Adds Weave.set_chunk_defaults!(:error => false) at the start of weave_file so that any code chunk throwing an uncaught error will fail the build. Also adds contributor guidelines to the README explaining how to properly handle error demonstrations using try/catch or the error=true chunk option. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weave.set_chunk_defaults!(:error => false)at the start ofweave_file, so benchmark builds now fail if any code chunk throws an uncaught error. Previously, Weave's default (error=true) would silently capture errors and include ugly stacktraces in published output.Motivation
Benchmarks should fail loudly when code errors unexpectedly, rather than silently producing output with stacktraces. This makes CI more useful for catching real regressions. Chunks that intentionally demonstrate errors (e.g., showing why a method was omitted) need to explicitly opt in via
error=trueor usetry/catchblocks.This pairs with PR #1511 which already wrapped existing error demonstrations in try/catch.
Changes
src/SciMLBenchmarks.jl: AddedWeave.set_chunk_defaults!(:error => false)as the first line ofweave_file. This sets the default for all chunks in every benchmark — individual chunks can still override witherror=true.README.md: Added a "Handling Method Omissions and Errors in Benchmarks" section under Contributing with:try/catch(preferred for friendly messages) anderror=truechunk optionTest plan
🤖 Generated with Claude Code