Refresh DAE under v7 stack - #1575
Draft
ChrisRackauckas-Claude wants to merge 2 commits into
Draft
Conversation
ChrisRackauckas-Claude
force-pushed
the
clean/DAE
branch
from
May 22, 2026 14:14
fcc4e76 to
749ab1b
Compare
Local smoke test passed: instantiate clean, scripts extract cleanly for all 14 .jmd files. Manifest refresh notable bumps: ModelingToolkit 11.24.1 -> 11.26.3, Symbolics 7.21.0 -> 7.24.2, SymbolicUtils 4.26.0 -> 4.30.1 (fixes precompile dup-definition), Sundials 6.1.0 -> 6.2.1, DASKR 3.1.0 -> 3.1.1, DASSL 3.0.0 -> 3.0.1, SciMLBase 3.7.1 -> 3.13.0, OrdinaryDiffEqBDF/Rosenbrock/FIRK/SDIRK 2.0 -> 2.x. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
…tolerances
charge_pump.jmd: Symbolics v7 removed the old derivative-registration API
(Symbolics.derivative(::typeof(f), ::NTuple, ::Val{i})). Replace with the
new @register_derivative macro for qgate, qsrc, qdrain (and vin). Verified
that expand_derivatives(D(qdrain(U1, U1-U2, U1-U3))) now expands to a sum
of dqdrain_i(...) * Differential(...) terms instead of a dangling
Differential(t,1)(qdrain(...)), and that @mtkbuild successfully reduces
the index-2 system from 9 unknowns down to 4.
fekete.jmd: The "High Tolerances" and "Timeseries Errors" WorkPrecisionSets
paired abstols = 10.0.^-(5:8) with reltols = 10.0.^-(1:4) element-wise.
The first pair (abstol=1e-5, reltol=1e-1) is too loose for Sundials, which
spins for hours emitting "error test failed repeatedly" before failing.
Tightened reltols to 10.0.^-(4:7) so abstol and reltol are within ~1 order
of each other (sane per-step error control), and added :verbose => false
to the IDA/DASKR setups dicts to silence Sundials' repeated-error-test
warnings on the still moderately-loose end of the grid. The existing
maxiters = Int(1e7) WorkPrecisionSet kwarg already caps runaway runtimes.
Other tolerance blocks (MM vs DAE vs MTK subset, Low Tolerances) already
use tighter pairings and were left unchanged.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas-Claude
force-pushed
the
clean/DAE
branch
from
May 31, 2026 01:12
749ab1b to
1a46f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified locally; Manifest refresh.
Summary
.jmdfiles underbenchmarks/DAEtangle cleanly withSciMLBenchmarks.weave_file(..., (:script,))on Julia 1.11 against the refreshed Manifest.autodiff/verbose,precs, integersol[i], old ensembleprob_func).Please ignore until reviewed by @ChrisRackauckas.