Make weave_folder re-throw at end if any .jmd failed (make CI accurate) - #1591
Merged
ChrisRackauckas merged 1 commit intoMay 22, 2026
Merged
Conversation
Per-file ProcessFailedException was previously caught and only @error'd, so benchmark.jl always exited 0 even when one or more .jmd files actually failed — CI showed green despite real failures (e.g. the ComplicatedPDE/Filament.jmd ADTypes missing-dep bug masked until SciML#1589). Collect failures and throw at end. Per-file 'continue on failure' behaviour is preserved (so one bad .jmd doesn't block others from producing artifacts), but the job now exits non-zero if anything failed. This will cause master CI to start showing red for folders that have been silently failing — that's the intended behaviour; the goal is for red CI to reflect real failures. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
May 22, 2026 14:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore until reviewed by @ChrisRackauckas.
What
weave_folderinsrc/SciMLBenchmarks.jlpreviously caught per-fileProcessFailedExceptionand only@error'd it, then returned normally. As a result,benchmark.jlalways exits 0 and the GHA job always goes green — even when one or more.jmdfiles actually failed.This PR collects per-file failures and throws at the end of
weave_folderif any happened. The 'continue past per-file failure' behaviour is preserved (so one bad.jmddoesn't block others from producing partial artifacts), but the job now exits non-zero if anything failed.Why
Real example: ComplicatedPDE was merged green in #1580 even though
Filament.jmdwas failing withPackage ADTypes not found in current path. Fix landed in follow-up #1589. Without this PR, future bugs of that shape will keep getting masked.Expected impact
Master CI will start showing red for folders that have been silently failing. Known candidates as of this writing:
using Multibodybut Multibody is not in [deps] AND not in Manifest. Pre-existing.These should be addressed separately; this PR just makes CI tell the truth.
Diff
Three new lines in
weave_folder:failures = Tuple{String,String}[]before the looppush!(failures, (folder, file))inside the catch blockisempty(failures) || error(...)after the loop🤖 Generated with Claude Code