Refresh nested manifests before benchmark builds - #1618
Draft
ChrisRackauckas-Claude wants to merge 1 commit into
Draft
Refresh nested manifests before benchmark builds#1618ChrisRackauckas-Claude wants to merge 1 commit into
ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Member
Author
|
Investigation scratchpad Task prompt: independently reproduce the clean-master Julia 1.12
No tests were skipped, disabled, loosened, or silenced. |
Member
Author
|
CI note: the immediate Spell Check failure is the two pre-existing |
Member
Author
|
Post-timer CI review:
No branch-local CI failure was found, so no additional change was pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1612 for the Julia 1.10-compatible
Testingmanifest.Summary
Root cause
Julia 1.12 no longer bundles
MbedTLS_jll, while the checked-in Julia 1.11Testingmanifest records it as a stdlib without a source tree.Pkg.instantiate()therefore leaves no package path for the subsequentPkg.build()call.A full bisect found
cc4abfcee7f55d5be8be72060f382c1de5d1742fas the first bad commit because it introduced and activated the nestedTestingenvironment. Resolving the manifest on same-or-newer Julia versions converts historical stdlibs such asMbedTLS_jllto normal registered packages before building.Verification
Pkg.test()passes on this branch, including ExplicitImports, the stale-manifest regression, and the real woven benchmark test.Pkg.test()passes when stacked on Regenerate Testing manifest with Julia 1.10 #1612.