Skip to content

Require OMJulia 0.3.1 - #1620

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:codex/require-omjulia-0-3-1
Jul 20, 2026
Merged

Require OMJulia 0.3.1#1620
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:codex/require-omjulia-0-3-1

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Summary

Ignore this PR until it has been reviewed by @ChrisRackauckas.

  • require OMJulia 0.3.1
  • avoid the duplicate ModelicaSystem definition in OMJulia 0.3.0

OMJulia 0.3.0 defines the same constructor twice during precompilation. Upstream removed the duplicate in commit 3b97b91; OMJulia 0.3.1 is the first tagged release containing the fix.

Dependencies

The clean base graph also selects precompile-broken IJulia 1.21.0, and its nested Julia 1.10 Testing manifest is independently stale. This one-line compat change is validated in a combined exact-floor stack with the IJulia 1.23.2 floor from #1619 and the manifest repair in #1612; those prerequisites remain separate reviewable changes.

Local validation

  • Exact downgrade resolution on Julia 1.10: selected OMJulia 0.3.1.
  • Exact-floor build on Julia 1.10: passed.
  • using OMJulia at the exact 0.3.1 floor: passed without the 0.3.0 method-overwrite failure.
  • Combined exact-floor package test with IJulia 1.23.2 and Regenerate Testing manifest with Julia 1.10 #1612: passed (Explicit Imports 2/2; weave_file 1/1).
  • Standalone current-resolution package test on Julia 1.12: Explicit Imports passed 2/2, then the test reproduced the clean-base nested-manifest MbedTLS_jll path failure tracked by Regenerate Testing manifest with Julia 1.10 #1612.
  • A fresh current-resolution rerun stacked with IJulia 1.23.2 and Regenerate Testing manifest with Julia 1.10 #1612 reached the same clean-base Julia 1.12 MbedTLS_jll path failure after Explicit Imports passed 2/2; the Julia 1.10 exact-floor stack remains the controlling compat validation.
  • Runic.main([\"--check\", \".\"]): passed.
  • git diff --check: passed.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

Investigation scratchpad for 7510ebff:

  • synchronized against SciML master at 0498ef25; changed only OMJulia = "0.3" to "0.3.1"
  • traced OMJulia 0.3.0's duplicate ModelicaSystem definition to upstream fix commit 3b97b91; OMJulia 0.3.1 is the first tagged release containing that fix
  • exact Julia 1.10 downgrade resolution selected OMJulia 0.3.1
  • exact-floor build and an isolated using OMJulia load passed without the 0.3.0 overwrite
  • full exact-floor package test stacked with IJulia 1.23.2 (Require IJulia 1.23.2 #1619) and the independent Testing-manifest repair (Regenerate Testing manifest with Julia 1.10 #1612) passed (Explicit Imports 2/2; weave_file 1/1)
  • fresh Julia 1.12 current resolution selected OMJulia 0.3.3; Explicit Imports passed 2/2, after which the suite reproduced the identical clean-base nested Testing-manifest MbedTLS_jll path failure
  • Runic --check and git diff --check passed

The current-runtime nested-manifest failure is recorded as clean-base behavior. The successful locked Julia 1.10 combined test is the controlling downgrade validation, while each compat change remains a separate one-line PR.

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member Author

CI classification: the spellcheck failure is identical to the clean-base SerPSO diagnostics already reproduced, bisected, and fixed separately in #1614.

This PR changes only the OMJulia compat line; neither reported location is in its diff. The Julia test remains queued/in progress, while the formatting checks are independent. No typo change will be stacked into this focused PR.

@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 20, 2026 06:40
@ChrisRackauckas
ChrisRackauckas merged commit 81ccd86 into SciML:master Jul 20, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants