Skip to content

Fix StiffBVP: replace obsolete nest_tol with nested_nlsolve_kwargs - #1621

Merged
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/fix-stiffbvp-nest-tol
Jul 24, 2026
Merged

Fix StiffBVP: replace obsolete nest_tol with nested_nlsolve_kwargs#1621
ChrisRackauckas merged 1 commit into
SciML:masterfrom
ChrisRackauckas-Claude:agent/fix-stiffbvp-nest-tol

Conversation

@ChrisRackauckas-Claude

Copy link
Copy Markdown
Member

Summary

BoundaryValueDiffEqFIRK removed the nest_tol keyword from FIRK algorithm constructors. It is replaced by nested_nlsolve_kwargs::NamedTuple.

Change

- RadauIIa7(nested_nlsolve = true, nest_tol = 1e-3)
+ RadauIIa7(nested_nlsolve = true, nested_nlsolve_kwargs = (; abstol = 1e-3, reltol = 1e-3))

in benchmarks/StiffBVP/ionic_liquid_dehumidifier.jmd.

Notes

BoundaryValueDiffEqFIRK removed nest_tol from the RadauIIa*/Lobatto*
constructors in favor of nested_nlsolve_kwargs::NamedTuple. Passing
nest_tol now errors; use abstol/reltol via nested_nlsolve_kwargs.

Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
@ChrisRackauckas
ChrisRackauckas marked this pull request as ready for review July 24, 2026 06:02
@ChrisRackauckas
ChrisRackauckas merged commit c31acd5 into SciML:master Jul 24, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants