Bio: isolate loser methods to show large cost without bloating main WP - #1623
Merged
ChrisRackauckas merged 1 commit intoJul 24, 2026
Merged
Conversation
BCR: drop dense Lapack, default dense Newton/linsolve, and unpreconditioned GMRES from the main work-precision suites; time each once against a sparse KLU reference in a dedicated "Loser methods (large cost in isolation)" section with a relative-cost bar chart. egfr_net / multisite2 / multistate: replace ROCK2 (and multistate CVODE_Adams) numruns=200 WP panels with single-solve isolation timings vs a competitive explicit reference, so the large cost is shown without dominating the suite. Main competitive summary diagrams are unchanged. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
ChrisRackauckas
marked this pull request as ready for review
July 24, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear losers on Bio were either (1) already documented as worse but still run
with
numruns = 200full WP panels (ROCK2 / CVODE_Adams), or (2) structuralnon-starters on large sparse stiff chemistry (BCR dense Lapack, default dense
Julia factorizations, GMRES without preconditioner) that still sat in the main
suites.
This PR keeps the heavy competitive work-precision suites, but moves those
losers into "Loser methods (large cost in isolation)" sections that
time each method once at a fixed tolerance next to a competitive
reference and plot relative wall time.
Changes
BCR.jmdegfr_net.jmdmultisite2.jmdmultistate.jmdCVODE+KLU on BCR remains a failure demo (diverges), not a timed loser.
Notes
numruns = 200blocks; only removesnon-competitive configs from multi-run WP.