Skip to content

Test heartbeat cleanup contract - #389

Merged
kojix2 merged 1 commit into
SciRuby:masterfrom
kojix2:heartbeat-cleanup-contract
May 31, 2026
Merged

Test heartbeat cleanup contract#389
kojix2 merged 1 commit into
SciRuby:masterfrom
kojix2:heartbeat-cleanup-contract

Conversation

@kojix2

@kojix2 kojix2 commented May 31, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds coverage for the session heartbeat cleanup behavior and clarifies the adapter contract around heartbeat shutdown.

Changes:

  • Extends the session close resource cleanup test to assert heartbeat thread start and completion.
  • Adds heartbeat lifecycle tracking to the test session adapter.
  • Updates the heartbeat setup comment to describe the cleanup contract.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/iruby/session_test.rb Verifies heartbeat lifecycle completion during Session#close.
lib/iruby/session.rb Clarifies the heartbeat adapter cleanup expectation in a comment.
lib/iruby/session_adapter/test_adapter.rb Tracks heartbeat start/finish state for tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kojix2
kojix2 merged commit 02114c6 into SciRuby:master May 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants