Skip to content

fix: sync Genshin HDR toggle with the actual game registry state - #1926

Open
loliri wants to merge 1 commit into
Scighost:mainfrom
loliri:main
Open

fix: sync Genshin HDR toggle with the actual game registry state#1926
loliri wants to merge 1 commit into
Scighost:mainfrom
loliri:main

Conversation

@loliri

@loliri loliri commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The Genshin HDR switch in game settings was initialized from AppConfig.EnableGenshinHDR only, so it could disagree with the game's real setting after HDR was toggled in-game or written by another tool
  • Add GameSettingService.GetGenshinEnableHDR reading the WINDOWS_HDR_ON_h3132281285 registry value (hk4e only), the read-side counterpart of the existing SetGenshinEnableHDR
  • The page now prefers the registry state and falls back to AppConfig when unavailable (non-hk4e, registry read failure, or value not present)

Test plan

  • Launch Genshin with HDR enabled in-game → the switch in Starward shows ON on page load
  • Toggle HDR off in-game, reopen the game settings page → the switch shows OFF
  • Non-Genshin games → switch still initializes from AppConfig as before

- The settings page initialized the Genshin HDR switch from AppConfig only, so it could disagree with the game's real setting after it was changed in-game or by another tool
- Add GameSettingService.GetGenshinEnableHDR reading the game registry value (hk4e only); the page falls back to AppConfig when unavailable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant