fix: sync Genshin HDR toggle with the actual game registry state - #1926
Open
loliri wants to merge 1 commit into
Open
fix: sync Genshin HDR toggle with the actual game registry state#1926loliri wants to merge 1 commit into
loliri wants to merge 1 commit into
Conversation
- The settings page initialized the Genshin HDR switch from AppConfig only, so it could disagree with the game's real setting after it was changed in-game or by another tool - Add GameSettingService.GetGenshinEnableHDR reading the game registry value (hk4e only); the page falls back to AppConfig when unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppConfig.EnableGenshinHDRonly, so it could disagree with the game's real setting after HDR was toggled in-game or written by another toolGameSettingService.GetGenshinEnableHDRreading theWINDOWS_HDR_ON_h3132281285registry value (hk4e only), the read-side counterpart of the existingSetGenshinEnableHDRAppConfigwhen unavailable (non-hk4e, registry read failure, or value not present)Test plan