Open
Conversation
Add the zk app to the main bucket
7 tasks
Contributor
|
Your changes do not pass checks. zk
|
Contributor
|
This submission is missing several parts of the manifest. Please update it. Please name your PR in the format: A working manifest that I tested locally with all required fields is below: {
"version": "0.15.1",
"description": "A plain text note-taking assistant",
"homepage": "https://github.com/zk-org/zk",
"license": "GPL-3.0-or-later",
"architecture": {
"64bit": {
"url": "https://github.com/zk-org/zk/releases/download/v0.15.1/zk-v0.15.1-windows-x86_64.tar.gz",
"hash": "b78d9b37ac14e6dc6150e6ee4c0ffa754935abbdafc584cea311dd6d71dff0ba"
}
},
"bin": "zk.exe",
"checkver": "github",
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/zk-org/zk/releases/download/v$version/zk-v$version-windows-x86_64.tar.gz"
}
}
}
} |
made changes as suggested by maintainer
fix syntax errors
make the linter happy
More linting fixes
Author
|
Ok I think I have fixed all of the issues you sent to me. |
fix url to zip file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the zk app to the main bucket
See package request for app here
#6779