Mill: Update to 1.0.2, Migrate to Native runner#7028
Open
nightscape wants to merge 1 commit intoScoopInstaller:masterfrom
Open
Mill: Update to 1.0.2, Migrate to Native runner#7028nightscape wants to merge 1 commit intoScoopInstaller:masterfrom
nightscape wants to merge 1 commit intoScoopInstaller:masterfrom
Conversation
Contributor
|
All changes look good. Wait for review from human collaborators. mill
|
Lutra-Fs
requested changes
Aug 12, 2025
| "homepage": "https://mill-build.com/", | ||
| "license": "MIT", | ||
| "suggest": { | ||
| "JDK": "java/openjdk" |
Member
There was a problem hiding this comment.
I would suggest removing OpenJDK deps as we have migrated to the native runner
| "url": "https://github.com/com-lihaoyi/mill/releases/download/0.12.5/0.12.5-assembly#/mill.bat", | ||
| "hash": "0c7b25412feecf06d955d013418de9a9080ce755bedbac7601c9109c33d5a057", | ||
| "bin": "mill.bat", | ||
| "url": "https://repo1.maven.org/maven2/com/lihaoyi/mill-dist-native-windows-amd64/1.0.2/mill-dist-native-windows-amd64-1.0.2.exe#/mill.exe", |
Member
There was a problem hiding this comment.
We should use
"architecture" field to limit the native runner only run with AMD64(64 bit) machine. Because https://mill-build.org/mill/cli/installation-ide.html#_mill_native_and_jvm_executables clearly states that the native one does not support ARM64 architecture
Lutra-Fs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<manifest-name[@version]|chore>: <general summary of the pull request>