Skip to content

fix build error for c++ std14#163

Open
sailfish009 wants to merge 2 commits intoSeanNaren:pytorch_bindingsfrom
sailfish009:pytorch_bindings
Open

fix build error for c++ std14#163
sailfish009 wants to merge 2 commits intoSeanNaren:pytorch_bindingsfrom
sailfish009:pytorch_bindings

Conversation

@sailfish009
Copy link
Copy Markdown

No description provided.

@Stonesjtu
Copy link
Copy Markdown

In my case I simply change the c++11 to c++14 of extra_compile_args in setup.py.

@Stonesjtu
Copy link
Copy Markdown

@SeanNaren can you review this PR, it's essential to compile correctly against pytorch-1.6

@SeanNaren
Copy link
Copy Markdown
Owner

Thanks @Stonesjtu it seems the build is working fine without modifying this flag. Could you send me the error you run into when you don't change this flag?

Maetveis pushed a commit to Maetveis/warp-ctc that referenced this pull request Feb 17, 2022
* add float64 input for warpctc

* add comment to function of double
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants