DAGE-20: added ElasticSearch support#185
Merged
nicolo-rinaldi merged 9 commits intoAug 12, 2025
Merged
Conversation
nicolo-rinaldi
force-pushed
the
ticket/DAGE-20_elasticsearch-support
branch
3 times, most recently
from
e8d485f to
1448039
Compare
nicolo-rinaldi
commented
Jul 25, 2025
nicolo-rinaldi
commented
Jul 25, 2025
nicolo-rinaldi
force-pushed
the
ticket/DAGE-20_elasticsearch-support
branch
2 times, most recently
from
7fc74a3 to
882b665
Compare
nicolo-rinaldi
changed the title
nseidan
reviewed
Jul 26, 2025
nseidan
previously approved these changes
Jul 26, 2025
nicolo-rinaldi
force-pushed
the
ticket/DAGE-20_elasticsearch-support
branch
from
882b665 to
70418b2
Compare
Intrinsical-AI
left a comment
Intrinsical-AI
left a comment
Collaborator
There was a problem hiding this comment.
I'd add parsing, typing, docstrings, and use pytests fixtures.
Also: I think it's needed to follow a general common implementation for the engines, as we're doing very diferent each one (further than syntax specifics)
nicolo-rinaldi
force-pushed
the
ticket/DAGE-20_elasticsearch-support
branch
from
3bec78d to
9dee1ca
Compare
Intrinsical-AI
previously approved these changes
Jul 30, 2025
Intrinsical-AI
left a comment
Intrinsical-AI
left a comment
Collaborator
There was a problem hiding this comment.
I think this is a very good refactor! I'm glad you decided to add it, thanks for the openess! 💯
nicolo-rinaldi
force-pushed
the
ticket/DAGE-20_elasticsearch-support
branch
from
9dee1ca to
ddbfd4e
Compare
Intrinsical-AI
previously approved these changes
Jul 31, 2025
dantuzi
reviewed
Aug 11, 2025
Collaborator
There was a problem hiding this comment.
I like it but, for the next time, please do refactoring and fixes in a separated Pr
dantuzi
reviewed
Aug 12, 2025
- updated SearchEngineFactory with elasticsearch support - created elasticsearch_search_engine.py file with the class needed for the integration and related unit test file - changed the names of the files used for test in the resources folder - added eleasticsearch-init folder with test environment for elasticsearch
…nd updated README.md file
…lr, since was exactly the same)
nicolo-rinaldi
force-pushed
the
ticket/DAGE-20_elasticsearch-support
branch
from
bfdfd94 to
bb18fb2
Compare
dantuzi
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket