Merge branch 'trunk' into py-affected-split

Author: titusfortner

Rakefile

@@ -143,13 +143,17 @@ task :format do |_task, arguments|
   Rake::Task['all:format'].invoke(*args)
 end
 
-desc 'Run linters (may auto-fix some issues; stricter checks than :format)'
-task :lint do
-  puts 'Linting shell scripts and GitHub Actions...'
+def lint_actions
   shellcheck = Bazel.execute('build', [], '@multitool//tools/shellcheck')
   Bazel.execute('run', ['--', '-shellcheck', shellcheck], '@multitool//tools/actionlint:cwd')
+end
 
-  Rake::Task['all:lint'].invoke
+desc 'Run linters (may auto-fix some issues; stricter checks than :format)'
+task :lint do
+  SeleniumRake.aggregate_errors(
+    shellcheck_and_actionlint: -> { lint_actions },
+    all: -> { Rake::Task['all:lint'].invoke }
+  )
 end
 
 # Legacy aliases - call namespaced tasks
@@ -215,24 +219,18 @@ namespace :all do
   desc 'Validate release credentials for all languages'
   task :check_credentials do |_task, arguments|
     args = arguments.to_a
-    failures = []
-    %w[java py rb dotnet node].each do |lang|
-      Rake::Task["#{lang}:check_credentials"].invoke(*args)
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:check_credentials"].invoke(*args) }]
     end
-    raise "Credential check failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Verify all packages are published to their registries'
   task :verify do
-    failures = []
-    %w[java py rb dotnet node].each do |lang|
-      Rake::Task["#{lang}:verify"].invoke
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:verify"].invoke }]
     end
-    raise "Verification failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Release all artifacts for all language bindings'
@@ -257,15 +255,10 @@ namespace :all do
 
   desc 'Run linters for all language bindings'
   task :lint do
-    all_langs = %w[java py rb dotnet node]
-    failures = []
-    all_langs.each do |lang|
-      puts "Linting #{lang}..."
-      Rake::Task["#{lang}:lint"].invoke
-    rescue StandardError => e
-      failures << "#{lang}: #{e.message}"
+    steps = %w[java py rb dotnet node].to_h do |lang|
+      [lang.to_sym, -> { Rake::Task["#{lang}:lint"].invoke }]
     end
-    raise "Lint failed:\n#{failures.join("\n")}" unless failures.empty?
+    SeleniumRake.aggregate_errors(**steps)
   end
 
   desc 'Update versions for all language bindings'

common/repositories.bzl

@@ -11,8 +11,8 @@ def pin_browsers():
 
     http_archive(
         name = "linux_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.2/linux-x86_64/en-US/firefox-151.0.2.tar.xz",
-        sha256 = "1f77a1aacc2a0ccbb36998875f04a9c22229103dc35cb4bbb89784f0809161e0",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.3/linux-x86_64/en-US/firefox-151.0.3.tar.xz",
+        sha256 = "b2405272cc3a8dde0fadeb5cea2b1fb03fc0a181b3015bd60985a63b04e70ed7",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -33,8 +33,8 @@ js_library(
 
     dmg_archive(
         name = "mac_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.2/mac/en-US/Firefox%20151.0.2.dmg",
-        sha256 = "232631dd169b8a4fc661a7a6756da3910cc669ba34b81858b7915ca138752e79",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/151.0.3/mac/en-US/Firefox%20151.0.3.dmg",
+        sha256 = "60d5cb29412b161c76ecc58f3f8a960cd0048081cf84c6fe91579f1957564277",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -50,8 +50,8 @@ js_library(
 
     http_archive(
         name = "linux_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b5/linux-x86_64/en-US/firefox-152.0b5.tar.xz",
-        sha256 = "c9215e26c5ee9d08ab7afbd04b7605f18a77beba062d3c013629c27860d5c106",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b7/linux-x86_64/en-US/firefox-152.0b7.tar.xz",
+        sha256 = "a30876a4025e6ba8a619bd7278f217abb894ffc60d6b691ece0b47ed7a72e995",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -72,8 +72,8 @@ js_library(
 
     dmg_archive(
         name = "mac_beta_firefox",
-        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b5/mac/en-US/Firefox%20152.0b5.dmg",
-        sha256 = "595f550d5e7c6230ec783777a6b4de287a73ea87b8fad739ad9c301f2d899ca0",
+        url = "https://ftp.mozilla.org/pub/firefox/releases/152.0b7/mac/en-US/Firefox%20152.0b7.dmg",
+        sha256 = "47f2d377abd82ff2ae9cd557996f6194ca92637c666565c1802760d1b6c14c5f",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -89,8 +89,8 @@ js_library(
 
     http_archive(
         name = "linux_geckodriver",
-        url = "https://github.com/mozilla/geckodriver/releases/download/v0.36.0/geckodriver-v0.36.0-linux64.tar.gz",
-        sha256 = "0bde38707eb0a686a20c6bd50f4adcc7d60d4f73c60eb83ee9e0db8f65823e04",
+        url = "https://github.com/mozilla/geckodriver/releases/download/v0.37.0/geckodriver-v0.37.0-linux64.tar.gz",
+        sha256 = "90d4e33bd9816684400c160d1309aaffec23a3f65103511d5a62d8501062e548",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -106,8 +106,8 @@ js_library(
 
     http_archive(
         name = "mac_geckodriver",
-        url = "https://github.com/mozilla/geckodriver/releases/download/v0.36.0/geckodriver-v0.36.0-macos-aarch64.tar.gz",
-        sha256 = "c045c8c0d859e6045defbb1c31b37ebeb3c942fc61daaf11e21fc634f2d71c52",
+        url = "https://github.com/mozilla/geckodriver/releases/download/v0.37.0/geckodriver-v0.37.0-macos-aarch64.tar.gz",
+        sha256 = "369165b614164f8adc43d8e017f55fe1ced208afe474be2f0cc1c01fc6529725",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -123,10 +123,10 @@ js_library(
 
     pkg_archive(
         name = "mac_edge",
-        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/eff0de67-2c4d-45ce-b8e2-f1ce8c69c595/MicrosoftEdge-148.0.3967.96.pkg",
-        sha256 = "d2056a5eb9972b7d7a3cb34fbfa313b43c2ddcd9c7282b1bbba7a48b55028087",
+        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/20523184-11bb-436b-a567-0e33fcaff5f2/MicrosoftEdge-149.0.4022.52.pkg",
+        sha256 = "d5c2e2616d8f397bda51b13fbcb87497cbc988662add896ffac4a093dd144195",
         move = {
-            "MicrosoftEdge-148.0.3967.96.pkg/Payload/Microsoft Edge.app": "Edge.app",
+            "MicrosoftEdge-149.0.4022.52.pkg/Payload/Microsoft Edge.app": "Edge.app",
         },
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -143,8 +143,8 @@ js_library(
 
     deb_archive(
         name = "linux_edge",
-        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_148.0.3967.96-1_amd64.deb",
-        sha256 = "ff447b27cb72767e033d38c5814709bd3b1eccadb32ac2a45f0fffdea8a5af49",
+        url = "https://packages.microsoft.com/repos/edge/pool/main/m/microsoft-edge-stable/microsoft-edge-stable_149.0.4022.52-1_amd64.deb",
+        sha256 = "de51617f1912f343f9f5d934d25a41a7ef0820552f4842551864df020871c388",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -165,8 +165,8 @@ js_library(
 
     http_archive(
         name = "linux_edgedriver",
-        url = "https://msedgedriver.microsoft.com/148.0.3967.96/edgedriver_linux64.zip",
-        sha256 = "b4f53b446acd6801396117eee46bdd100ea8a6110e6c1d8d3bb421d8dff4d5b8",
+        url = "https://msedgedriver.microsoft.com/149.0.4022.52/edgedriver_linux64.zip",
+        sha256 = "edf675b58fd133c0a36d9575f37a2b71ca6bf9e299c188bce89245a96dd3648b",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -182,8 +182,8 @@ js_library(
 
     http_archive(
         name = "mac_edgedriver",
-        url = "https://msedgedriver.microsoft.com/148.0.3967.96/edgedriver_mac64_m1.zip",
-        sha256 = "934a9aa94bd3faa60773507e65c3ea75f45d571bf24a229256638f9c88bf97aa",
+        url = "https://msedgedriver.microsoft.com/149.0.4022.52/edgedriver_mac64_m1.zip",
+        sha256 = "1433027e3ef2bb847ca1ad77cb5235d7ef215fea287827ecdd644d0c69435fb3",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -199,8 +199,8 @@ js_library(
 
     http_archive(
         name = "linux_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/linux64/chrome-linux64.zip",
-        sha256 = "05b6843867b4ee40f280327b748397a158b84ccbe20b94c3e89740d15422988f",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chrome-linux64.zip",
+        sha256 = "a77e3ba8fa8cf299a1a980313a162ea1a5d33297f632d5d3c7f553f7cf6780d4",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -220,8 +220,8 @@ js_library(
     )
     http_archive(
         name = "mac_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/mac-arm64/chrome-mac-arm64.zip",
-        sha256 = "2d6a26edcbdd39d38ddfe7a0f11cb315eea7d0c5bbf2e3200ecdaa2855bc2bf5",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chrome-mac-arm64.zip",
+        sha256 = "376b22526a92345db188f8750be8a5abc45d1c8dda3805bfe89bf3327a10062f",
         strip_prefix = "chrome-mac-arm64",
         patch_cmds = [
             "mv 'Google Chrome for Testing.app' Chrome.app",
@@ -241,8 +241,8 @@ js_library(
     )
     http_archive(
         name = "linux_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/linux64/chromedriver-linux64.zip",
-        sha256 = "8fd9b1efe5c97191690d1e90f5d61eb323d82b44e38da09e65fecf9bbed86730",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chromedriver-linux64.zip",
+        sha256 = "27a25d270195552a75e72c86d425b39e4bd1da51d7a6df9fc9071629e3a0acbf",
         strip_prefix = "chromedriver-linux64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -259,8 +259,8 @@ js_library(
 
     http_archive(
         name = "mac_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/148.0.7778.178/mac-arm64/chromedriver-mac-arm64.zip",
-        sha256 = "7be431042c78b6452ee0684afa2e3f0838653266503557513613362aeea7a4b8",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chromedriver-mac-arm64.zip",
+        sha256 = "58cb81188172ecf2db41f7704538942017ebc9e1bdb822151f9721c7066849c2",
         strip_prefix = "chromedriver-mac-arm64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -277,8 +277,8 @@ js_library(
 
     http_archive(
         name = "linux_beta_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chrome-linux64.zip",
-        sha256 = "a77e3ba8fa8cf299a1a980313a162ea1a5d33297f632d5d3c7f553f7cf6780d4",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/linux64/chrome-linux64.zip",
+        sha256 = "71b143f17eb6eeefb07bcee867f42d39942940b8e6bb57072410235a5fd7215c",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
 package(default_visibility = ["//visibility:public"])
@@ -298,8 +298,8 @@ js_library(
     )
     http_archive(
         name = "mac_beta_chrome",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chrome-mac-arm64.zip",
-        sha256 = "376b22526a92345db188f8750be8a5abc45d1c8dda3805bfe89bf3327a10062f",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/mac-arm64/chrome-mac-arm64.zip",
+        sha256 = "24975dcc97ede4093437e84d8a05d270a7cc176e86d9fd64ad91fc705694d20e",
         strip_prefix = "chrome-mac-arm64",
         patch_cmds = [
             "mv 'Google Chrome for Testing.app' Chrome.app",
@@ -319,8 +319,8 @@ js_library(
     )
     http_archive(
         name = "linux_beta_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/linux64/chromedriver-linux64.zip",
-        sha256 = "27a25d270195552a75e72c86d425b39e4bd1da51d7a6df9fc9071629e3a0acbf",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/linux64/chromedriver-linux64.zip",
+        sha256 = "98552d432041578e922d91065fcee2536ececa6b3c3b8a9a01686636bca8763a",
         strip_prefix = "chromedriver-linux64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")
@@ -337,8 +337,8 @@ js_library(
 
     http_archive(
         name = "mac_beta_chromedriver",
-        url = "https://storage.googleapis.com/chrome-for-testing-public/149.0.7827.54/mac-arm64/chromedriver-mac-arm64.zip",
-        sha256 = "58cb81188172ecf2db41f7704538942017ebc9e1bdb822151f9721c7066849c2",
+        url = "https://storage.googleapis.com/chrome-for-testing-public/150.0.7871.5/mac-arm64/chromedriver-mac-arm64.zip",
+        sha256 = "144c0245b33c58b62b31a120b008a677977400c7982729a86823b22580510710",
         strip_prefix = "chromedriver-mac-arm64",
         build_file_content = """
 load("@aspect_rules_js//js:defs.bzl", "js_library")

javascript/selenium-webdriver/test/firefox/addon_test.js

@@ -19,7 +19,7 @@
 
 const assert = require('node:assert')
 const { Browser } = require('selenium-webdriver/index')
-const { Pages, suite } = require('../../lib/test')
+const { ignore, Pages, suite } = require('../../lib/test')
 const { locate } = require('../../lib/test/resources')
 const { until, By } = require('selenium-webdriver/index')
 
@@ -61,7 +61,9 @@ suite(
           await verifyWebExtensionNotInstalled()
         })
 
-        it('installs and uninstalls by unsigned zip file', async function () {
+        // Temporarily installed unsigned extensions no longer inject content scripts
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=2045054
+        ignore(env.browsers(Browser.FIREFOX)).it('installs and uninstalls by unsigned zip file', async function () {
           await driver.get(Pages.blankPage)
           await verifyWebExtensionNotInstalled()
 
@@ -89,7 +91,9 @@ suite(
           await verifyWebExtensionNotInstalled()
         })
 
-        it('installs and uninstalls by unsigned directory', async function () {
+        // Temporarily installed unsigned extensions no longer inject content scripts
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=2045054
+        ignore(env.browsers(Browser.FIREFOX)).it('installs and uninstalls by unsigned directory', async function () {
           await driver.get(Pages.blankPage)
           await verifyWebExtensionNotInstalled()
 
@@ -103,7 +107,9 @@ suite(
           await verifyWebExtensionNotInstalled()
         })
 
-        it('installs and uninstalls by signed directory', async function () {
+        // Installs the unsigned directory temporarily, so hits the same bug
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=2045054
+        ignore(env.browsers(Browser.FIREFOX)).it('installs and uninstalls by signed directory', async function () {
           await driver.get(Pages.blankPage)
           await verifyWebExtensionNotInstalled()
 

py/test/selenium/webdriver/firefox/ff_installs_addons_tests.py

@@ -67,6 +67,7 @@ def test_install_uninstall_signed_addon_zip(driver, pages):
     assert len(driver.find_elements(By.ID, "webextensions-selenium-example")) == 0
 
 
+@pytest.mark.xfail_firefox(reason="https://bugzilla.mozilla.org/show_bug.cgi?id=2045054")
 @pytest.mark.no_driver_after_test
 def test_install_uninstall_unsigned_addon_zip(driver, pages):
     extension = os.path.join(EXTENSIONS, "webextensions-selenium-example-unsigned.zip")
@@ -107,6 +108,7 @@ def test_install_uninstall_signed_addon_dir(driver, pages):
     assert len(driver.find_elements(By.ID, "webextensions-selenium-example")) == 0
 
 
+@pytest.mark.xfail_firefox(reason="https://bugzilla.mozilla.org/show_bug.cgi?id=2045054")
 @pytest.mark.no_driver_after_test
 def test_install_uninstall_unsigned_addon_dir(driver, pages):
     zip = os.path.join(EXTENSIONS, "webextensions-selenium-example-unsigned.zip")

rake_tasks/common.rb

@@ -107,6 +107,20 @@ def self.update_changelog(version, language, path, changelog, header)
     File.write(changelog, "#{header}\n#{entries}\n\n#{content}")
   end
 
+  def self.aggregate_errors(**steps)
+    failures = steps.filter_map do |name, closure|
+      label = name.to_s.tr('_', ' ')
+      puts "Running #{label}..." unless name == :all
+      closure.call
+      nil
+    rescue StandardError => e
+      "#{label}: #{e.message}"
+    end
+    return if failures.empty?
+
+    raise failures.join("\n\n")
+  end
+
   def self.verify_package_published(url)
     puts "Verifying #{url}..."
     uri = URI(url)

rake_tasks/dotnet.rake

@@ -127,14 +127,16 @@ end
 
 desc 'Run .NET linter (dotnet format analyzers, docs)'
 task :lint do
-  puts '  Running dotnet format analyzers...'
-  Bazel.execute('run', ['--', 'analyzers', '--verify-no-changes'], '//dotnet:format')
-  Rake::Task['dotnet:docs_generate'].invoke
+  steps = {
+    dotnet_format_analyzers: -> { Bazel.execute('run', ['--', 'analyzers', '--verify-no-changes'], '//dotnet:format') },
+    dotnet_docs: -> { Rake::Task['dotnet:docs_generate'].invoke }
+  }
 
-  # TODO: Identify specific diagnostics that we want to enforce but can't be auto-corrected (e.g., 'IDE0060'):
   enforced_diagnostics = []
-  next if enforced_diagnostics.empty?
+  if enforced_diagnostics&.any?
+    arguments = %w[-- style --severity info --verify-no-changes --diagnostics] + enforced_diagnostics
+    steps[:dotnet_format_style] = -> { Bazel.execute('run', arguments, '//dotnet:format') }
+  end
 
-  arguments = %w[-- style --severity info --verify-no-changes --diagnostics] + enforced_diagnostics
-  Bazel.execute('run', arguments, '//dotnet:format')
+  SeleniumRake.aggregate_errors(**steps)
 end

rake_tasks/python.rake

@@ -172,9 +172,9 @@ end
 
 desc 'Run Python linters (ruff check --no-fix, mypy, docs)'
 task :lint do
-  puts '  Running ruff check (verify)...'
-  Bazel.execute('run', ['--', '--no-fix'], '//py:ruff-check')
-  puts '  Running mypy...'
-  Bazel.execute('run', [], '//py:mypy')
-  Rake::Task['py:docs_generate'].invoke
+  SeleniumRake.aggregate_errors(
+    ruff_check: -> { Bazel.execute('run', ['--', '--no-fix'], '//py:ruff-check') },
+    mypy: -> { Bazel.execute('run', [], '//py:mypy') },
+    python_docs: -> { Rake::Task['py:docs_generate'].invoke }
+  )
 end