Fixes issue add support for more datatypes in filtersMore datatypes (updated) - #146
Open
thomas-topway-it wants to merge 17 commits into
Open
thomas-topway-it wants to merge 17 commits into
thomas-topway-it wants to merge 17 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
============================================
+ Coverage 81.41% 81.60% +0.19%
- Complexity 736 757 +21
============================================
Files 36 36
Lines 2507 2566 +59
Branches 7 7
============================================
+ Hits 2041 2094 +53
- Misses 461 467 +6
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thomas-topway-it
marked this pull request as draft
July 3, 2026 13:05
thomas-topway-it
marked this pull request as ready for review
July 3, 2026 13:27
Contributor
Author
|
@gesinn-it-gea there are 2 tests failing however it looks like this dummy #147 pull request created as a reference |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes: Fix tagcloud SemanticResultFormats#1050
fixes Add support for more datatypes in filters (e.g. keyword, quantity) #3
fixes single option in #drilldownlink produces error #10
Adds support for all default SMW datatypes and fixes use of predefined datatypes as property label. (e.g.
[[Email::test@mail.com]], but also[[Number::123]]) --- see tables below for a precise reference between master and this pull request.adds support for the following datatypes:
The following tables show the difference between master and this pull request. Note that most of the predefined/pre-deployed data types come with a predefined special page. (see the 3rd table) . This could be taken into account for future development to fix the differences between the 2 versions.
In few cases (e.g. "record", "keyword" and "reference") master performs better using the 'page' datatype. However, based on this data, the present PR use the same datatype in these cases as a temporary solution, so it performs better than master in any case. (except possible errors to be fixed).
MASTER
PULL REQUEST