Skip to content

Fixes issue add support for more datatypes in filtersMore datatypes (updated) - #146

Open
thomas-topway-it wants to merge 17 commits into
SemanticMediaWiki:masterfrom
Knowledge-Wiki:more-datatypes
Open

thomas-topway-it wants to merge 17 commits into
SemanticMediaWiki:masterfrom
Knowledge-Wiki:more-datatypes

Conversation

@thomas-topway-it

Copy link
Copy Markdown
Contributor

Adds support for all default SMW datatypes and fixes use of predefined datatypes as property label. (e.g. [[Email::test@mail.com]], but also [[Number::123]]) --- see tables below for a precise reference between master and this pull request.

adds support for the following datatypes:

  • Annotation URI
  • Geographic coordinates
  • Keyword
  • Monolingual text
  • Telephone number
  • Temperature
  • URL
  • Quantity
  • Code
  • Email

The following tables show the difference between master and this pull request. Note that most of the predefined/pre-deployed data types come with a predefined special page. (see the 3rd table) . This could be taken into account for future development to fix the differences between the 2 versions.

In few cases (e.g. "record", "keyword" and "reference") master performs better using the 'page' datatype. However, based on this data, the present PR use the same datatype in these cases as a temporary solution, so it performs better than master in any case. (except possible errors to be fixed).

MASTER

datatype user-defined label predefined label
Text
Code
Boolean
Number
Geographic coordinates
Temperature
Date
Email
URL
Annotation URI
Telephone number
Record ✓ (but wrong)
Quantity
Monolingual text ✓ (but wrong)
External identifier
Keyword
Reference

PULL REQUEST

datatype user-defined label predefined label
Text
Code
Boolean
Number
Geographic coordinates
Temperature
Date
Email
URL
Annotation URI
Telephone number
Record ✓ (using 'page')
Quantity
Monolingual text
External identifier
Keyword ✓ (using 'page')
Reference ✓ (using 'page')
datatype has predefined property page
Text yes
Code yes
Boolean yes
Number yes
Geographic coordinates yes
Temperature yes
Date yes
Email yes
URL yes
Annotation URI yes
Telephone number yes
Record no
Quantity yes
Monolingual text yes
External identifier yes
Keyword no
Reference no

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.65306% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.60%. Comparing base (34c9b45) to head (a27a474).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
includes/Sql/SqlProvider.php 63.15% 7 Missing ⚠️
includes/Filter.php 88.00% 6 Missing ⚠️
includes/AppliedFilter.php 25.00% 3 Missing ⚠️
includes/Specials/BrowseData/GetCategories.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
+ Coverage     81.41%   81.60%   +0.19%     
- Complexity      736      757      +21     
============================================
  Files            36       36              
  Lines          2507     2566      +59     
  Branches          7        7              
============================================
+ Hits           2041     2094      +53     
- Misses          461      467       +6     
  Partials          5        5              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-topway-it
thomas-topway-it marked this pull request as draft July 3, 2026 13:05
@thomas-topway-it
thomas-topway-it marked this pull request as ready for review July 3, 2026 13:27
@thomas-topway-it

thomas-topway-it commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@gesinn-it-gea there are 2 tests failing however it looks like this dummy #147 pull request created as a reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for more datatypes in filters (e.g. keyword, quantity) single option in #drilldownlink produces error

1 participant