Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Python 3.13 shutdown hang in the Sendspin TUI by removing reliance on the asyncio event loop’s default executor for blocking readchar.readkey() calls, instead reading keys on a dedicated background thread and forwarding them into the asyncio loop.
Changes:
- Add a dedicated daemon thread to perform blocking
readchar.readkey()reads. - Forward keypresses back to the asyncio loop via
loop.call_soon_threadsafe()and anasyncio.Queue. - Replace
run_in_executor()usage withawait key_queue.get()in the main keyboard loop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readchar.readkey()callsTesting