fix: Responsiveness for low width - #33
Draft
koger23 wants to merge 1 commit into
Draft
Conversation
SVG line was not responsive in smaller size, it has overflow on the left. Removing height solved the issue, but aligned the svg lower to the bottom, which seemed to be fixed by adding 3px padding to the bottom.
Sese-Schneider
requested changes
Jul 31, 2024
Sese-Schneider
left a comment
Sese-Schneider
left a comment
Owner
There was a problem hiding this comment.
Hi @koger23,
Thank you for your PR.
Unfortunately, the change breaks the "normal" view:
main:
width: 100%;
height: 15px;PR:
width: 100%;
padding: 3px;
Author
|
Oh, sorry about that, I forgot to test it on greater screen, I will working on it. |
Sese-Schneider
changed the title
Sese-Schneider
marked this pull request as draft
August 6, 2024 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG line was not responsive in smaller size, it had overflow on the left.
Removing height solved the issue, but aligned the svg lower to the bottom compared to the original solution, which seemed to be fixed by adding 3px padding to the bottom.
Before:
After:
